emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Nikolay Kudryavtsev <nikolay.kudryavtsev@gmail.com>
Cc: emacs-orgmode <emacs-orgmode@gnu.org>
Subject: Re: manual: stale bindings for org-clock-report and org-columns-insert-dblock
Date: Sun, 10 Mar 2019 21:52:06 +0100	[thread overview]
Message-ID: <8736nusb9l.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <42595f5a-cde8-efcc-158d-654b90b33362@gmail.com> (Nikolay Kudryavtsev's message of "Sat, 9 Mar 2019 23:09:17 +0300")

Hello,

Nikolay Kudryavtsev <nikolay.kudryavtsev@gmail.com> writes:

> I was able to debug the Icicles interaction bug:
>
> In org-dblock-write:clocktable there's a check ((pred functionp)
> (funcall scope)) which checks whether the scope is a function. Since
> the default scope is currently "file", it gets funcalled. Icicles
> provides a function called file. There it can be disabled by setting
> (setq icicle-define-alias-commands-flag nil), but getting to that
> would generally mean that the user ran into some problems and did the
> same debugging I had to do.

Icicles is doing it wrong. Packages are supposed to provide only
prefixed functions, since there is no namespace in Emacs.

> I'm not 100% sure but I'd rather prefer org not calling any functions
> with generic names like "file" or "subtree", so maybe prepending some
> predicate on a call is warranted, so instead of "file", something like
> "org-scope-file" would get checked, but I don't really understand the
> intended use of this feature.

I pushed a different change. Tell me if it fixes your issue.

> As for dynamic reloading, I retested and can confirm that it's broken
> since 69c300bbf. To repeat, start with elpa org, add master org to the
> load path, do org-reload.

So, you are doing a mixed installation on purpose. No wonder you have
troubles. Don't reload a different installation on top of a loaded one.

Regards,

-- 
Nicolas Goaziou

next prev parent reply	other threads:[~2019-03-10 21:04 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-11  2:19 manual: stale bindings for org-clock-report and org-columns-insert-dblock Kyle Meyer
2019-01-11 11:37 ` stardiviner
2019-03-03 15:44 ` Nikolay Kudryavtsev
2019-03-03 17:14   ` Kyle Meyer
2019-03-04 15:16     ` Nikolay Kudryavtsev
2019-03-04 16:11       ` Nicolas Goaziou
2019-03-05  1:51         ` Nikolay Kudryavtsev
2019-03-09 20:09         ` Nikolay Kudryavtsev
2019-03-10 20:52           ` Nicolas Goaziou [this message]
2019-05-07 15:40             ` Nikolay Kudryavtsev
2019-03-04 18:32       ` Nick Dokos
2019-03-04 13:26   ` stardiviner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8736nusb9l.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=nikolay.kudryavtsev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).