emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Kyle Meyer <kyle@kyleam.com>
To: Ihor Radchenko <yantar92@gmail.com>
Cc: Bastien Guerry <bzg@bzg.fr>, emacs-orgmode@gnu.org
Subject: Re: Bug: org-with-wide-buffer is used in org-refile.el without (require 'org-macs) [9.3.6 (release_9.3.6-441-gba6855 @ /home/yantar92/.emacs.d/straight/build/org/)]
Date: Fri, 10 Apr 2020 03:22:45 +0000	[thread overview]
Message-ID: <87369c2fei.fsf@kyleam.com> (raw)
In-Reply-To: <878sj74lfp.fsf@localhost>

Ihor Radchenko <yantar92@gmail.com> writes:

> Recently, I ran into a problem compiling org-mode asynchronously with
> each .el file being compiled in a separate process (via
> native-compile-async).
> When I tried to compile org-refile.el in a separate Emacs process
> (without compiling all other .el files), there was no way for the
> byte-compiler to know that org-with-wide-buffer is a macro.

Thanks for the report.  Unfortunately, this is fallout from the movement
of some org.el components to org-refile.el in f636cf91b (New
org-refile.el file with refile definitions, 2020-02-05).

> As I understand, normally org-mode compiles synchronously with all the
> .el files being byte-compiled in alphabetic order. Then,
> (eval-and-compile (require 'org-macs)) from org.el is defined prior
> compiling all the org-*.el files, which accidentally allow the org-mode
> to be compiled without any issues.

There's also a 'make single' target that compiles files separately.  My
understanding is that ideally its output should be free of warnings.
Running that right before the commit above (f636cf91b^), there are a
couple of warnings (at least one now resolved).  There are a lot after,
including the one you mention.

There have been at least a couple of threads that bring up related
org-refile.el issues:

  - https://yhetil.org/orgmode/CAFyQvY1VR5t_a=JO01+QWbUQk_9i8+2XG6W2-mg-DpFzjz9seg@mail.gmail.com/
  - https://yhetil.org/orgmode/8861c9e9-6c19-ea8f-6a90-7a466782096f@thompsonclan.org/

So, there's a lot we need to fix here :/

next prev parent reply	other threads:[~2020-04-10  3:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-07 10:52 Bug: org-with-wide-buffer is used in org-refile.el without (require 'org-macs) [9.3.6 (release_9.3.6-441-gba6855 @ /home/yantar92/.emacs.d/straight/build/org/)] Ihor Radchenko
2020-04-10  3:22 ` Kyle Meyer [this message]
2020-04-16  2:54   ` Kyle Meyer
2020-05-31 14:49     ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87369c2fei.fsf@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=bzg@bzg.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=yantar92@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).