From: Matthew Lundin <mdl@imapmail.org>
To: numbchild@gmail.com
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH v2] Re: [BUG] recently commits on master branch breaks command 'org-babel-demarcate-block'
Date: Sun, 31 May 2020 20:12:23 -0500 [thread overview]
Message-ID: <87367fh9mw.fsf@fastmail.fm> (raw)
In-Reply-To: <87k10r1upi.fsf@gmail.com>
stardiviner <numbchild@gmail.com> writes:
> Matthew Lundin <mdl@imapmail.org> writes:
>
>>
>> I think you also need to replace the newline with a space in the upper
>> case version.
>>
> Supposed there is \n after #+end_src. I also checked the original version before
> that change commit. The original has an newline. I write patch by comparing
> before and after (side by side).
I'm referring to this line in the patch:
indent (if upper-case-p "#+BEGIN_SRC\n" "#+begin_src ")
^
The newline that needs to be removed is indicated by "^".
You can see a correct similar version of this line on line 1932 of
ob-core.el.
The original line the problematic commit replaced would also have had a
space in both, since it called either downcase or upcase on the string
"#+begin_src ".
Best,
Matt
next prev parent reply other threads:[~2020-06-01 1:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-30 2:03 [BUG] recently commits on master branch breaks command 'org-babel-demarcate-block' stardiviner
2020-05-30 20:57 ` Berry, Charles via General discussions about Org-mode.
2020-05-31 3:02 ` [PATCH] " stardiviner
2020-05-31 3:07 ` [PATCH v2] " stardiviner
2020-05-31 16:47 ` Matthew Lundin
2020-06-01 0:43 ` stardiviner
2020-06-01 1:12 ` Matthew Lundin [this message]
2020-06-01 7:32 ` [PATCH v3] " stardiviner
2020-06-01 13:50 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87367fh9mw.fsf@fastmail.fm \
--to=mdl@imapmail.org \
--cc=emacs-orgmode@gnu.org \
--cc=numbchild@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).