From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id OrQxC2cH119VDAAA0tVLHw (envelope-from ) for ; Mon, 14 Dec 2020 06:34:15 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id GGSbBmcH11/LSgAA1q6Kng (envelope-from ) for ; Mon, 14 Dec 2020 06:34:15 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CB42F94042B for ; Mon, 14 Dec 2020 06:34:14 +0000 (UTC) Received: from localhost ([::1]:35972 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kohQz-0001iT-N5 for larch@yhetil.org; Mon, 14 Dec 2020 01:34:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52154) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kohQB-0001gb-Dl for emacs-orgmode@gnu.org; Mon, 14 Dec 2020 01:33:23 -0500 Received: from mail-pl1-x641.google.com ([2607:f8b0:4864:20::641]:34178) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kohQ9-00078m-Po; Mon, 14 Dec 2020 01:33:23 -0500 Received: by mail-pl1-x641.google.com with SMTP id t6so8108456plq.1; Sun, 13 Dec 2020 22:33:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:date:in-reply-to :message-id:mime-version; bh=ZqTXoH2KsTYyD/baLhZB0TuHYxjh5dXg24cF+ugmYFU=; b=TPi1qdjH+wP3Kt2lQnUA+WTFI3zk6+vefbba0XuIUagAGFvZg+W7B9rTvh6Dp/iOZ9 DWJIxjnaS0X7VjClsHe1E9ThH5hANeO751CI+AP+4H0SxlSV4ZNV5cmwUovL2n9JTM0D iG0kZj1V6GXszZEFJS3rmJ2z6OWJv6aNKOY+E5Cn4wDA3Q2CvKJ8TxqdGBGYr0UNA3Wa TTO3M6ZDKzojkneMe1+FsgFyBsE775RZzmbAAnHkk6jIknqtfc6BVTQCdXx/H5CRf1rP IPFkg2S7EZ+BMV6lyIspkBCVyEIQfpJ4HcF/OEawJu8plp34/C/aV6d8LfDnVPlsTOQ4 t4gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject:date :in-reply-to:message-id:mime-version; bh=ZqTXoH2KsTYyD/baLhZB0TuHYxjh5dXg24cF+ugmYFU=; b=DjOyorlgyRJSG3v+kRaZy0G1jq4yoeAmUtTfry4D2cYXJmOaHj12MUhwCtI2UNGKNM dOIeSUXtz0gE+kc9KXlAudK12Y2qaqg3gsMVoSH/1Rw4ItC9S7G/uSTcG6WiQyvMMAmX RRL9MQHnoUtqph6WHNhF7l/yiTI0qTHkbfRDpGdLn7+7mPt3os+wCx1pgcbcZeb254KV +R97a/F5wVtzoqQoHwHe93owIipZXjXhjfbkBy8SvFiTYIAGCNTIOsJ3oRhXoa0eDplG HsG62rzMLO3hns7g0PVUjYfh2/zaEggIiWMNs0uQU3rHyweZwaF3NrzvsE288yIWRx1D QuPA== X-Gm-Message-State: AOAM531eiSebvB/UxCwkqlL0l5q6jY2SUSvIDIuimBjJvT6jQ9fY0l6V AVbUnZgdQMp2USYfc99colhln063xsc= X-Google-Smtp-Source: ABdhPJzjgd5g+EHH7oE6FBPlF7X7KA3WB56YkuTnSauIbDCfcGpkOlVdntU1ym4EEIKqhmkaK2SUQQ== X-Received: by 2002:a17:90a:a48c:: with SMTP id z12mr23470115pjp.58.1607927599775; Sun, 13 Dec 2020 22:33:19 -0800 (PST) Received: from localhost (180-150-91-8.b4965b.per.nbn.aussiebb.net. [180.150.91.8]) by smtp.gmail.com with ESMTPSA id r17sm1047915pfr.153.2020.12.13.22.33.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Dec 2020 22:33:19 -0800 (PST) References: <87imcrfntf.fsf@gmail.com> <87blijmnv9.fsf@gnu.org> <87lfhbhfhe.fsf@gmail.com> <87r1qp3fu1.fsf@gmail.com> <871rhxd2ib.fsf@gmail.com> <87r1pnoo5y.fsf@bzg.fr> <87lffv8oy5.fsf@gmail.com> <87zh2hosex.fsf@bzg.fr> User-agent: mu4e 1.4.13; emacs 27.1 From: TEC To: Bastien Subject: Re: [PATCH] org-plot abstractions and extension Date: Mon, 14 Dec 2020 14:30:53 +0800 In-reply-to: <87zh2hosex.fsf@bzg.fr> Message-ID: <8736086gno.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::641; envelope-from=tecosaur@gmail.com; helo=mail-pl1-x641.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: org-mode-email Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -3.00 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=TPi1qdjH; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: CB42F94042B X-Spam-Score: -3.00 X-Migadu-Scanner: scn1.migadu.com X-TUID: 24jw/L+jQA77 Bastien writes: > Applied, with minor modifications of the changelog entries: > > - You need to add an entry when creating a new custom variable. > > - I suggest saying "option" instead of "custom variable". > > - Sentences should be separated by two spaces and start with an > uppercase letter. > > Also, the convention in Emacs is to avoid whitespaces-only commits, > you need to fix whitespaces within other non-whitespaces changes in > a commit. Thanks for the feedback on the patches! I tried to get it right after my previous (and first) attempt, but it looks like there are a few things I still need to take note of. Big improvement though, nonetheless, hopefully next time they'll be nothing to change :) All the best, Timothy