From: Jeremie Juste <jeremiejuste@gmail.com>
To: "Berry, Charles" <ccberry@health.ucsd.edu>
Cc: Jack Kamm <jackkamm@gmail.com>, Org Mode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] async process in R
Date: Mon, 27 Sep 2021 22:28:43 +0200 [thread overview]
Message-ID: <8735ppdapw.fsf@debian-BULLSEYE-live-builder-AMD64> (raw)
In-Reply-To: <08FCAE37-4D75-4E06-9FA2-7E2939F74709@health.ucsd.edu> (Charles Berry's message of "Mon, 27 Sep 2021 18:28:33 +0000")
[-- Attachment #1: Type: text/plain, Size: 707 bytes --]
Hello Chuck,
On Monday, 27 Sep 2021 at 18:28, Berry, Charles wrote:
>
> It looks like you have `(setq ess-eval-visibly t)' here. I think that is a default setting.
Thanks again for your suggestion. The following patch to be applied on
top of the previous one, solves the issue.
#+begin_src R :session *R* :results output :async yes
Sys.sleep(5)
1:5
#+end_src
#+RESULTS:
: [1] 1 2 3 4 5
The function (ess-eval-buffer), when the parameter VIS is nil, misled me in the sense that it inverses
the value of ess-eval-visibly.
Note as well that all the tests in test-ob-R.el passed including the
tests for async evaluation from [1] ob-session-async.
[1]: https://github.com/jackkamm/ob-session-async/.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: patch-2 --]
[-- Type: text/x-diff, Size: 1077 bytes --]
From 795cc0ebe637aa4ff148c495cf5403ba2baec242 Mon Sep 17 00:00:00 2001
From: Jeremie Juste <djj@debian-BULLSEYE-live-builder-AMD64>
Date: Mon, 27 Sep 2021 22:02:17 +0200
Subject: [PATCH] ob-R.el: Patch async evaluation when :results output
* lisp/ob-R.el (ob-session-async-org-babel-R-evaluate-session): Make
sure that 'ess-eval-visibly' is nil before evaluating the temporary
buffer, but return ess-eval-visibly to it's original state afterwards.
---
lisp/ob-R.el | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/lisp/ob-R.el b/lisp/ob-R.el
index 299ccdf1d..188b9ac8f 100644
--- a/lisp/ob-R.el
+++ b/lisp/ob-R.el
@@ -526,8 +526,11 @@ by `org-babel-comint-async-filter'."
(insert body)
(insert "\n")
(insert (format ob-session-async-R-indicator
- "end" uuid))
+ "end" uuid))
+ (setq tmp ess-eval-visibly)
+ (setq ess-eval-visibly nil)
(ess-eval-buffer nil))
+ (setq ess-eval-visibly tmp)
uuid))))
(defun ob-session-async-R-value-callback (params tmp-file)
--
2.30.2
[-- Attachment #3: Type: text/plain, Size: 70 bytes --]
Thanks again to Jack for this useful feature.
Best regards,
Jeremie
next prev parent reply other threads:[~2021-09-27 20:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-26 17:13 Jeremie Juste
2021-09-26 18:33 ` Greg Minshall
2021-09-26 19:52 ` Jeremie Juste
2021-09-27 4:04 ` Greg Minshall
2021-09-27 6:48 ` Bastien
2021-09-27 19:21 ` Jeremie Juste
2021-09-28 3:02 ` Jack Kamm
2021-09-27 8:18 ` Bastien
2021-09-27 18:28 ` Berry, Charles via General discussions about Org-mode.
2021-09-27 19:25 ` Jeremie Juste
2021-09-27 20:28 ` Jeremie Juste [this message]
2021-09-27 22:56 ` Berry, Charles via General discussions about Org-mode.
2021-09-27 23:40 ` Berry, Charles via General discussions about Org-mode.
2021-09-28 7:34 ` Jeremie Juste
2021-09-28 18:22 ` Berry, Charles via General discussions about Org-mode.
2021-09-28 20:40 ` Jeremie Juste
2021-10-02 22:57 ` Jack Kamm
2021-10-02 22:54 ` Jack Kamm
2021-10-02 23:14 ` Jack Kamm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8735ppdapw.fsf@debian-BULLSEYE-live-builder-AMD64 \
--to=jeremiejuste@gmail.com \
--cc=ccberry@health.ucsd.edu \
--cc=emacs-orgmode@gnu.org \
--cc=jackkamm@gmail.com \
--subject='Re: [PATCH] async process in R' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox:
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).