From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 4Ci5C7Ryp2FxCwEAgWs5BA (envelope-from ) for ; Wed, 01 Dec 2021 14:03:48 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id cJJ9B7Ryp2HOVQAA1q6Kng (envelope-from ) for ; Wed, 01 Dec 2021 13:03:48 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BFE2D25078 for ; Wed, 1 Dec 2021 14:03:47 +0100 (CET) Received: from localhost ([::1]:58544 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1msPH0-0007nl-As for larch@yhetil.org; Wed, 01 Dec 2021 08:03:46 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60402) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1msPFq-0007n2-MF for emacs-orgmode@gnu.org; Wed, 01 Dec 2021 08:02:34 -0500 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:49771) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1msPFm-0004Oa-OJ for emacs-orgmode@gnu.org; Wed, 01 Dec 2021 08:02:32 -0500 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 067D44000D; Wed, 1 Dec 2021 13:02:24 +0000 (UTC) From: Nicolas Goaziou To: Kaushal Modi Subject: Re: [PATCH] Fix org-comment-line-break-function References: <87lf18fue9.fsf@aquinas.i-did-not-set--mail-host-address--so-tickle-me> <87v90cpcdx.fsf@yandex.com> <87ilwcf31l.fsf@aquinas.i-did-not-set--mail-host-address--so-tickle-me> <87pmqjkai3.fsf@gmail.com> <87fsrffknl.fsf@aquinas.i-did-not-set--mail-host-address--so-tickle-me> <87czmijtrp.fsf@gmail.com> <87o861o9sh.fsf@aquinas.i-did-not-set--mail-host-address--so-tickle-me> <87h7btpfbt.fsf@gmail.com> <87zgpli5nc.fsf@gmail.com> Date: Wed, 01 Dec 2021 14:02:23 +0100 In-Reply-To: (Kaushal Modi's message of "Tue, 30 Nov 2021 20:44:36 -0500") Message-ID: <8735nc1ns0.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=217.70.183.194; envelope-from=mail@nicolasgoaziou.fr; helo=relay2-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Lawrence , Marco Wahl , Tim Cross , emacs-org list Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1638363827; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=2au+DgqrGShAbJR+d1nUoR9moRQwfTFngZN0BbBo++8=; b=DJEZQf58gjDGw3eSMETyhIqIXIKgHNwLSASPlcRWpgdfAJDIxf2jRFrZxWvdYBKov2Bin8 49E6CG9X5tDxB2Usr4r1lYpzym/YnRNOuO3PRtAKBzyAOuHuAJAWC2p1hiXf+MCOIm0W/p iFc0hAB7Qpwf2rB06FAgspfELBM9Mpe2BUHdyVxB+QWc4SBQuyGTF5NiX0FwCg/+ThwmUV SucKH8ba8LjFxFQnMydsC1p2DVGlOXU+fNowlNNEvzPa8M8+mA2rZLtcv+PNI98uAA+DbM 8yVf1p9/fNZNNijl9R5YP6B6MO8c+km47rq8DIlwgw4UxrYJvgDlSGlT3WWQ+w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1638363827; a=rsa-sha256; cv=none; b=su7MJcdEiGc526XS/EhP9b0rEer60lXPNUfkU/LCGbddF+SLkboR1AHHRoNO+xRZyGNsrb ddwxuFtYr1EtIgUQY2H1/a2E7wSWGrpSU7Obj16DL1wLK+y76i6jpCEwzcMfxD5oMRrt0y 7+2GmRfI2HvPnu1kFjO7+A9Ltz6gjCYhB+X68xk8qY+JUzyWuvNvlDmgW7d2nrV3GyTkpa HpbMJxwBEaOZxmDu9y5PhJQDmvcOKU3GUXdj5IEgHoOwpjVymBV/8UZLDy++wRMnSY89Pl MPRD27P5F8aT8Lmb20QgM9WxwyCI52HIdGuopMUl98IBToa7+tl0oh44M9f8cQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.51 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: BFE2D25078 X-Spam-Score: -1.51 X-Migadu-Scanner: scn0.migadu.com X-TUID: PzPUfuhQ8icg Hello, Kaushal Modi writes: > I see that comment-indent-new-line was added to emacs in newcomment.el back > in 2000. So I don't know why org-comment-line-break-function was added. May > be Nicolas can comment more on that. Sorry, I do not remember. As pointed out in the thread, this function probably wasn't meant to be public in the first place. Now it is. > So would this patch work? Such a patch must be accompanied with tests. Regards, -- Nicolas Goaziou