From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 2A8GCP7NYmIAPQAAbAwnHQ (envelope-from ) for ; Fri, 22 Apr 2022 17:47:10 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id QLYfCP7NYmKMwgAA9RJhRA (envelope-from ) for ; Fri, 22 Apr 2022 17:47:10 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A0EEE29460 for ; Fri, 22 Apr 2022 17:47:09 +0200 (CEST) Received: from localhost ([::1]:36870 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nhvUy-0001xE-RU for larch@yhetil.org; Fri, 22 Apr 2022 11:47:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37484) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nhvUK-0001x1-OY for emacs-orgmode@gnu.org; Fri, 22 Apr 2022 11:46:28 -0400 Received: from mail-qv1-xf35.google.com ([2607:f8b0:4864:20::f35]:37677) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nhvUI-0006Tq-U3 for emacs-orgmode@gnu.org; Fri, 22 Apr 2022 11:46:28 -0400 Received: by mail-qv1-xf35.google.com with SMTP id kd22so1431720qvb.4 for ; Fri, 22 Apr 2022 08:46:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=OopoDAfcfwL5Ww+Rzeg5A0vtY0ELZV0KtHN1JtdQvbk=; b=D9F+NikMhG72X54gOCPYbccodg/6FouIc571VdtPrHUhd/9RkH6YSEaZv4qDi9vMvV spSY7LY3Zzugv85l+gxW71oo0w4aihjPiPQDqRshJ2MzKxF/qa9AN4deeJMn452RaUeR d+Rlg0cdxWVb2/v0G0aAErFmmPvCcm9r3KPZbr02dTccw2mPCpkTId+9TTtv718oxJtY 7FIfJYbPhVUwnAPCSl207UV0JL8RqLm6nYWXW+J+WMlh9oJoSQzAJU/JCOZsC7xs2qtE FDI6+o5ZiYfM8ua0sZ+s/2qKT1weDhPsB6d5lL8TGUwQvh+CTPIhz0pzgCpdfmqj5LKu Hryw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=OopoDAfcfwL5Ww+Rzeg5A0vtY0ELZV0KtHN1JtdQvbk=; b=QissSTZqSNXY6KK3tcNz0FIEbCCg2AnOjpGgn8WTuicn+dZO21UZfNZlerymH3aev8 BfFad3ltB9V+OHCeq4l8plW4IvcxMDg73iFOOMNog7MX/8j2pyUusdZiAG3gzQMNKjI9 7i7Q8WHzCy3hxCTaRKSst0Sj6EapZplPoJLsR1ErbUIaclkPh0PIAAXTQaLWGM12kQSO y5aXJccpdmokJLiIFzQx2bTm8hXMM98Cid4YfxNixIwPC54bog9P4bQXRNCRF7PxMNHS lAvVld04cUhjrg/gC+HI90hJSekhiy3fdDMJFuZF2rZ78WP2dqVxMziar7BEmxteZUcX UvPg== X-Gm-Message-State: AOAM531lcrDq6XlMI/h4Dht0Cc+QWjrSQJHqfd9ngkld4kFvblY+YAkY ZbuzrN6fl/nduEdRtg6N9sAfsGlXw0g= X-Google-Smtp-Source: ABdhPJzo8y+PXynbi80gqJj9IiA021hpOlZb/mn3G0h18g8DfFd/d5iLqNcMyzufNyEvdsZ1Gd2OPA== X-Received: by 2002:ad4:5bee:0:b0:444:474e:22d9 with SMTP id k14-20020ad45bee000000b00444474e22d9mr4197349qvc.117.1650642385560; Fri, 22 Apr 2022 08:46:25 -0700 (PDT) Received: from moondust.localdomain.nodomain.none (bras-base-toroon474qw-grc-79-174-92-60-96.dsl.bell.ca. [174.92.60.96]) by smtp.gmail.com with ESMTPSA id h75-20020a379e4e000000b0069db8210ffbsm1041663qke.12.2022.04.22.08.46.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Apr 2022 08:46:25 -0700 (PDT) From: "N. Jackson" To: Ihor Radchenko Subject: Re: [PATCH v2] org-agenda: Use `window-max-chars-per-line' to calculate max text width References: <874k2qwn92.fsf@moondust.localdomain> <87ee1ubje8.fsf@localhost> <87o80yqkhi.fsf@moondust.localdomain> <874k2ppxth.fsf@localhost> <87czhdqi9p.fsf_-_@moondust.localdomain> <87o80wz9le.fsf@localhost> <87ee1sjcf9.fsf@moondust.localdomain> <87wnfj3t4x.fsf@localhost> <87a6cekitg.fsf@moondust.localdomain> <875yn2vphr.fsf@moondust.localdomain> <875yn1u0at.fsf@localhost> <87czh9ecfl.fsf@moondust.localdomain> <87y1zxsc1z.fsf@localhost> Date: Fri, 22 Apr 2022 11:46:24 -0400 In-Reply-To: <87y1zxsc1z.fsf@localhost> (Ihor Radchenko's message of "Fri, 22 Apr 2022 17:27:20 +0800") Message-ID: <8735i5w27j.fsf@moondust.localdomain> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::f35; envelope-from=nljlistbox2@gmail.com; helo=mail-qv1-xf35.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1650642429; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=OopoDAfcfwL5Ww+Rzeg5A0vtY0ELZV0KtHN1JtdQvbk=; b=ue1zKCHRJMQWTgi6QoPgNLxPTHYsUU3631F0SkHOsGGgLXT02dK8IO/NYXdb8echqwT6Wl lwxVJrrgtUYOXo9e7u0gBp6KpXggDxwVxP7l5z0e92BKQHLkGHIieTKakAUnpp5OevMymL 8vAkrQCJEYVc3sUXDG5Hpdzi1BNmI/MJnoKLLrL0eRYNVZt4wNlMSO3iUG3on5GRWfQg+V M8TAexuWnOFVv8+0v512oajW1vkphCW8WHnzIc7tIfobjtdH87Eu/CQkYl3Erw70JpzYhD fgrSg8NKFcW7Ck3ZR/nzloe3Q9qjc3q5EYurv8Eb5Xr0QGLh3hWzUJOzCJuWpA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1650642429; a=rsa-sha256; cv=none; b=LD6edVN4RW4aSNzD3gfbqNzQH78yUiJkDxpU/Ba0lstg/Cy8Aoq4OES2Xf7Bf2dUBk3AWs PqH8vNDHuPXJjvQpvbMUftvet9au9Q7Iul1o5jecVLvNT6wkx1Uzzw0FrpJ/6GMe190INI lqDZASJ4/wyZFY7i2bhynGo9VqGgLqtK9zWNOs+XiBWEU8vmck2kFjLftvW2Y1F30n1ayw jMGfW8kBZa814cjve0mCATKIA+ynvPkTGb7UuJ2+n9jWEex3IIZnMT3nBPDqI32tO6NDLn b2T+ZumGRj48GUeAXENjApYSV+XhPomxumQOfv2FhOL2wDSaDFNxC9c055bvPA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=D9F+NikM; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.52 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=D9F+NikM; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: A0EEE29460 X-Spam-Score: -2.52 X-Migadu-Scanner: scn1.migadu.com X-TUID: zIAxIg9HkXdY At 17:27 +0800 on Friday 2022-04-22, Ihor Radchenko wrote: > > "N. Jackson" writes: >> >> If Org needs to support versions of Emacs before 25.1 then I assume >> you need the same guard on every instance of >> window-max-chars-per-line -- because window-max-chars-per-line was >> added to Emacs at the same time as window-font-width: > > We do not need to worry about this. Org supports the latest released > Emacs version + 2 previous [1]. Now, it means Emacs >=26. > > [1] https://orgmode.org/worg/org-maintenance.html#emacs-compatibility Ah, I didn't know that. Thanks. I have tested with your v2 patch applied to Org 9.5.3: 1. It fixes the two bugs I reported in this thread (with one or both fringes off, Agenda wraps `auto' (right) aligned tags unnecessarily and wraps the block separator). 2. It also makes the Agenda display properly after the font size has been altered with C-x +/-. This didn't work before, even with default fringes. [One has to hit `g' to refresh the Agenda after changing the font size.] 3. As is to be expected, it doesn't help with an Agenda displayed with a proportional font -- but it doesn't seem to make things any worse. FWIW a summary of my testing of tags alignment, separator width, and new time stamps for various fringe modes is shown below. 1. With my normal default font (-PfEd-DejaVu Sans Mono-normal-normal-normal-*-11-*-*-*-m-0-iso10646-1): |----------------+-------+-----------+-------+-----------+-------+-----------| | | Tags alignment | Separator width | New time | | Fringe mode +-------+-----------+-------+-----------+-------+-----------| | | 9.5.3 | +v2 Patch | 9.5.3 | +v2 Patch | 9.5.3 | +v2 Patch | |----------------+-------+-----------+-------+-----------+-------+-----------| | Default (Both) | OK | OK | OK | OK | OK | OK | | Minimal | OK | OK | OK | OK | OK | OK | | Left only | FAIL | OK | FAIL | OK | OK | OK | | Right only | FAIL | OK | FAIL | OK | OK | OK | | No fringes | FAIL | OK | FAIL | OK | OK | OK | |----------------+-------+-----------+-------+-----------+-------+-----------| 2. After `C-x + + +' and also `C-x - - -' (giving -PfEd-DejaVu Sans Mono-normal-normal-normal-*-21-*-*-*-m-0-iso10646-1 and -PfEd-DejaVu Sans Mono-normal-normal-normal-*-7-*-*-*-m-0-iso10646-1): |----------------+-------+-----------+-------+-----------+-------+-----------| | | Tags alignment | Separator width | New time | | Fringe mode +-------+-----------+-------+-----------+-------+-----------| | | 9.5.3 | +v2 Patch | 9.5.3 | +v2 Patch | 9.5.3 | +v2 Patch | |----------------+-------+-----------+-------+-----------+-------+-----------| | Default (Both) | FAIL | OK | FAIL | OK | OK | OK | | Minimal | FAIL | OK | FAIL | OK | OK | OK | | Left only | FAIL | OK | FAIL | OK | OK | OK | | Right only | FAIL | OK | FAIL | OK | OK | OK | | No fringes | FAIL | OK | FAIL | OK | OK | OK | |----------------+-------+-----------+-------+-----------+-------+-----------| 3. With a proportional font (-1ASC-Liberation Sans-normal-normal-normal-*-13-*-*-*-*-0-iso10646-1): |----------------+-------+-----------+-------+-----------+-------+-----------| | | Tags alignment | Separator width | New time | | Fringe mode +-------+-----------+-------+-----------+-------+-----------| | | 9.5.3 | +v2 Patch | 9.5.3 | +v2 Patch | 9.5.3 | +v2 Patch | |----------------+-------+-----------+-------+-----------+-------+-----------| | Default (both) | FAIL | FAIL | FAIL | FAIL | OK | OK | | Minimal | FAIL | FAIL | FAIL | FAIL | OK | OK | | Left only | FAIL | FAIL | FAIL | FAIL | OK | OK | | Right only | FAIL | FAIL | FAIL | FAIL | OK | OK | | No fringes | FAIL | FAIL | FAIL | FAIL | OK | OK | |----------------+-------+-----------+-------+-----------+-------+-----------| Note: My testing of the position of the new time stamps was only cursory. I never pay attention to them in normal use. I just checked that they were approximately right aligned. [I think, in fact, that both before and after your patch the behaviour isn't quite correct -- the stamps appear to be one character too far to the left. Of course that is barely noticeable and there are clearly far far more important things in Org to be worked on.] Regards, N.