From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id qCIFNVcxxWPmuwAAbAwnHQ (envelope-from ) for ; Mon, 16 Jan 2023 12:13:27 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id kEMbNFcxxWPOVAEAG6o9tA (envelope-from ) for ; Mon, 16 Jan 2023 12:13:27 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A64D524312 for ; Mon, 16 Jan 2023 12:13:27 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pHNQ3-00045X-Gy; Mon, 16 Jan 2023 06:12:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHNQ1-00045L-CA for emacs-orgmode@gnu.org; Mon, 16 Jan 2023 06:12:49 -0500 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHNPz-0005MQ-HY for emacs-orgmode@gnu.org; Mon, 16 Jan 2023 06:12:49 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 45AD9240054 for ; Mon, 16 Jan 2023 12:12:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1673867565; bh=gB6EM2ylRt1eMJDuCSWEOf6/kCbgZ70X97vzve0vWA4=; h=From:To:Cc:Subject:Date:From; b=gzhWh6li+bK3XtL9JzUSp15pU0F/w/5gvylmKrzxoWb6W+tMW5p0CWw0reMNzJuzO B3Giy5253lSKLSpRUPQLBKADXy4UiwRlS6gM83BclyPvsOy05rNcPp+fsjkxavxZn7 p42aGRFhHQxMRDJI6C2eUrhoPQmLhMA625HosxSsFQyiuSt9c2jPx3o06d/dOyVKNg rkyyavFVD4hIYl2CpbktKimbc5uWeCXHiOfsraoBBHaesxlR5RwPLnvoUqY/Eq3TXc vsVYQPi7mbaA1j/ZzfDg6gbqmdahBGQ7JuBWSebBbGOGtCk37l9mkhIPdzmoWBHsFN zDgvdI5GqtATg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4NwTrq0KQNz6tm9; Mon, 16 Jan 2023 12:12:42 +0100 (CET) From: Ihor Radchenko To: Daniel Kraus Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] ob-sql: Add support for Athena In-Reply-To: <874jsqbvfq.fsf@kraus.my> References: <874jsqbvfq.fsf@kraus.my> Date: Mon, 16 Jan 2023 11:13:13 +0000 Message-ID: <87358an35i.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1673867607; a=rsa-sha256; cv=none; b=hJFgL8hiOBiPehGEfmDOElz1FjCA9cw75+cf/VH9C71v1NN5oQinFrd7ELN3pZNlMMSP96 DS2sMmGONla3swHYfIHcPhRe06Fn5wiR1pjFo+rbb7qS2Qo4+7SgjJZVhjN2flBo4tlP3r jDBS66NdAMZcS6JOv1suCrNHCqS8rONkWXGztj8U8VplRTsCup485HTVQzuz75dWq5V/MC yh5mxJRdjYaXN4ch14wVXVpGiq5eCBle63S7WMK07BKrvTefnNT3QXz9hAiOwkO8XqJjUA 4RWDbTxYvIhImSBmuC2+NQStnD2aKXkFadFaKkEiFE5E2WGuJO1qvme2uLjVfg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=gzhWh6li; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1673867607; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=++A3BRoTea6QVO7q18gb9Gdx2f3GDkTIHSGTeCgnHRA=; b=g9sOBLiAwd2sli/lMi9+7gZ6oqvZcw/cdjy0KxhPqammNri3LfDkypz9jfPwvZYmUj3Nxh XWiFdpE49a8im3e5Zd+mQ1R5p5GHZyJIOZkHjYTpR1MnGz2zj+z6N4PqMdVd7R1M9nVKeQ EozDqOxoLOA8EqfxmBSo7FWvM4g0kgyYIZN7kBZy9YBPFm4N/FxqjLWyBcvZHlvsKW2LwJ +Ug/zAnVarTfv3v3dAmbp15dN7pWm924FLDf8IlEQqJkrb4q8+gC4XTZG320YzFxceIRkC 1AlgTXLKMoxFZdu/+jJL5ucOn2A1BBq504BPME7sC+xTN/wkGSq37kmW+QIsvA== X-Migadu-Spam-Score: -6.07 X-Spam-Score: -6.07 X-Migadu-Queue-Id: A64D524312 X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=gzhWh6li; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net X-TUID: 5ZRS2/Bjr2jE Daniel Kraus writes: > I'm using this patch since a few month that adds support > for AWS Athena. > The only thing that's maybe against adding it is that > `athenacli` (https://github.com/dbcli/athenacli) is not an > official AWS tool but just a Python script. > > What's the opinion on this? Is this something commonly used? I see two main issues with the idea: 1. I do not like the idea of adding all the possible CLI tools over there in ad-hoc manner. It would be cleaner to provide a customization to add various cli tools in a defcustom/defvar without manually changing the functions. 2. I feel like it will be hard to maintain such unpopular clients. If (1) is addressed + good automatic tests are implemented, things may be acceptable for inclusion though. In summary, I am not against the idea of including a new sql cli, but we should better provide a centralized API to do so and make sure that we have test coverage, making sure that things are not broken in future, when the original committer is gone and nobody else is left familiar with specific obscure SQL client. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at