From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id IK3OHXVTxWPKCAAAbAwnHQ (envelope-from ) for ; Mon, 16 Jan 2023 14:39:01 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id ABMuHnVTxWOxGgEAauVa8A (envelope-from ) for ; Mon, 16 Jan 2023 14:39:01 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 37C74FAC4 for ; Mon, 16 Jan 2023 14:39:01 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pHPge-0002Y9-4u; Mon, 16 Jan 2023 08:38:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHPgb-0002XG-TM for emacs-orgmode@gnu.org; Mon, 16 Jan 2023 08:38:05 -0500 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHPgZ-0002mR-KP for emacs-orgmode@gnu.org; Mon, 16 Jan 2023 08:38:05 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 7662C240133 for ; Mon, 16 Jan 2023 14:38:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1673876281; bh=Tg8h9s5ifC4lsT6TApTdj/BctSz2Hm7ikLKAQ8HfKmk=; h=From:To:Cc:Subject:Date:From; b=K4y+VSUXQtjAhU4NK0Q5+dpmt/qJmw0KreLnTAghQ8Hx+ngcUh65XBEnp0P1IORit XIAABVnQyAXpjpO6jEMyHt2G5DSCuc+8iaLvDUGuRjjrH82NUPyHSVDFNSYNJAi5lL RknSagrBMJs3QxqsV9KG5NfyLEgv2FZTvG5kv6zhlbfhjuqn0qPoaSg7ZaIWthgqLW y8H9MEQy2/6AkKC2XwU9azIvsWfYojLx3L3yY82GZ2NSFb7EaLuFf15KbMIvll097W vTzThHzarjbh+3tHAfmfJy0zZVwSweclegvU/GDU4WsE189hAM5GsOVguL0M2nApfo oc5Rq9TiQKtHA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4NwY4R1bn1z6tmG; Mon, 16 Jan 2023 14:37:59 +0100 (CET) From: Ihor Radchenko To: No Wayman Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] Support building Org from shallow clone [9.6.1 (release_9.6.1-137-gecb62e @ /home/n/.emacs.d/elpaca/builds/org/)] In-Reply-To: <87r0vvr2ai.fsf@gmail.com> References: <87r0vvr2ai.fsf@gmail.com> Date: Mon, 16 Jan 2023 13:38:30 +0000 Message-ID: <87358alhux.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=K4y+VSUX; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Seal: i=1; s=key1; d=yhetil.org; t=1673876341; a=rsa-sha256; cv=none; b=Pwv0At4hzQPMs9J1lVOH7vJjk4KYBxhM6C/a4sWnsiicH+JniR0hEApGPIspxcqxUJMiKg AAfolijLnvbetUrXyl/ygsTFmJjktXCsPa9rCSSToJKWyu+WK70WSqXhCXZbb3FNLbt/os rXM2V/tHekc/8cQn4whut2eXNBXtnKYGpfwjmS4e1Yqm6enotV4ZC2eP3MoEk/1b2Ki+lU LlkGzgk3T3CjmYWP0NUJip2j808VDdGkpvabxQ4oa6hcOMimpR6DGE9r47r08iyykxwzGn FDy0dYmKP4xQL7YUWhAH/ARGhaHjuOFgqwePSOWYc51fRHfznLaOJIamMQ8whw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1673876341; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=4rLAXVuqWbEB8Uo/Huv2tlj6MTVmKRgEFvdRPHyaJno=; b=VnmX8iA/p9Lo2rorGTa62VYu4iU+5U2v8gvAaFNo56H6k0fetZJrzkGFxLsKIZ1Lwb0RbO iRgtvOnM1waXxb6HgcnayAkJqk7xVegzha3bxbarEgjHjsCf+RLR0ORPTr1pGj7yY+ZyjJ IRhNJ0fZAlNGrKYc5KH8Zf4DZQXCAkh0mq4K9ECSC5r3ez+w6zQ1Snv9/9U79+RyjYXcf5 U2eMjc/m1y8BklF9LvcxjL5tw3QT3O7Zd+z5DRyXBy47EwoiePx//6tXFXjmYLlgBgfh3V kNkHoNVQ3cM3L4WcqHFrFQN5j8minEFmIHs1f4rMAGxieoFv9p++cVMvycsMAg== X-Migadu-Queue-Id: 37C74FAC4 X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=K4y+VSUX; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net X-Migadu-Spam-Score: -8.17 X-Spam-Score: -8.17 X-TUID: KdPqQcAjka9k No Wayman writes: > In order to properly generate org-version.el, the current build in > mk/targets.mk requires a query of the repo's tags. Shallow clones > do not have tags and so org-version will be generated as "N/A". In > the attached patch, support for generating org-version.el from > shallow clones is added. It is done by querying the upstream > remote via git ls-remote and parsing the output. In this case, a > more well formed org-version string will be generated. However, it > will be missing the "commits since last tag" information. e.g. > > "release_9.6.1-n/a-gabc123" As discussed, this is a reasonable addition. However, I am concerned about the following scenario: 1. Shallow clone is created 2. make autoloads is issues when system is disconnected from internet May it be properly handled? We can put N/A at the version tag as well in such case. What we should not have is "make autoloads" failing without internet. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at