From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id mBSJBl9C4mNwmgAAbAwnHQ (envelope-from ) for ; Tue, 07 Feb 2023 13:21:51 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id KG2mBV9C4mNLAgAAG6o9tA (envelope-from ) for ; Tue, 07 Feb 2023 13:21:51 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DAC70301FF for ; Tue, 7 Feb 2023 13:21:50 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pPMyE-0002B1-Vw; Tue, 07 Feb 2023 07:21:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pPMxz-00026a-21 for emacs-orgmode@gnu.org; Tue, 07 Feb 2023 07:20:58 -0500 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pPMxt-0006qc-7N for emacs-orgmode@gnu.org; Tue, 07 Feb 2023 07:20:53 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 254672403A3 for ; Tue, 7 Feb 2023 13:20:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1675772447; bh=JQ3Hg923M2M6KbGWpLQxH0iVg0kpsBeAcnva89rlcb4=; h=From:To:Cc:Subject:Date:From; b=osgxB/WEM6ULFJcLjKp4FPJH3SLErMw/cbjwYl4Og5b8ZVMpic2Wq/0bU4/+LUd2p JmS0/niViY4WH2irB/vWxUMNc6PQB9T1KA11kGlS36oWpBG0DlfkReovIQZ3KyL+oD G8iw52/yd21jW7io4avHyLEkW/SdS9wiOC+HxLsQc3A12oZhHCKC32HWM3OqnqXLcU bZzY6PhGUJXakr77HjgqwqZ3M3KgzyUVi4Q2Mp/zYUzc38G1WyfCjQZ7D0TMeslrdm tufixASFEtfv+vLdwt23PkaPfrdl9zxlrQXQhM6bA9rJuw5kcAkS6QtlB33CsJOwBx Xc8pq1jtEYHog== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4PB2K76PSXz6tmK; Tue, 7 Feb 2023 13:20:43 +0100 (CET) From: Ihor Radchenko To: Max Nikulin Cc: Rudolf =?utf-8?Q?Adamkovi=C4=8D?= , emacs-orgmode@gnu.org Subject: Re: [PATCH] ox-texinfo: Fix invalid syntax in Texinfo version detection code In-Reply-To: <2cae1646-a4ee-f856-d27e-0ee924aad4bc@gmail.com> References: <20230206214216.64841-1-salutis@me.com> <2cae1646-a4ee-f856-d27e-0ee924aad4bc@gmail.com> Date: Tue, 07 Feb 2023 12:21:22 +0000 Message-ID: <87357hfyyl.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b="osgxB/WE"; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Seal: i=1; s=key1; d=yhetil.org; t=1675772510; a=rsa-sha256; cv=none; b=Kdl7R2IzBrT6xwqjpIA8Jrcktwo+0hcN5OtBm3bxHx6r/2P/o8oZ35yXB8esRWiZ8/Vwx2 9AAYfHp5yyxd8CMlUG7j66NobbsFQs/VAqLciWSBn/0ufQEPcbOTUx1h/K7N/9fTwreMhy xVhseWC4Yw5MPE44CjLtsI0OsFpeesjo0bzA00K/IXEHzk9m5dMhoGjXPtrlmTlADRt1JW aPlJIrVFAYnofEyp9/TIFdYUtJWz1/+zaG9CKVgiMHzGrWBtDEhLRItxZXzEdBRqeiSd4L Cj5ZmOafDKJUb9NKiXTwr3VopERN6H0ALNiXqo9TXC1hkLZBCPfoUMBNG3QbEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1675772510; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=ReVYdw8pfuk1Xbw35zSdUjFTvMTH4Fay5xaJacXbwVE=; b=KUbLUhX1aSgFPKVIG/MJFfueCrh4jJF2M2DCGN8jgjDPcJbcf5YolHA7ICDLPSbo8BX3A4 e0t9nMaB0HNWu+wHlpQvsCDmMhMkxNbqebSbFSLXbBHEjeLif57jQLT3XdN18wXmMsSgJM CFzIoz73XI1mVJ9FcQDa1XvwLBGyA7gtSv4hfKC6ebaDDOfQfsezHkk9lc//8IlLqBWucG oZ0azstY7KQRz5Nye7ARs4MouGNopEztQ1XrofJ5um3gF/akI3CvxYr7LvSvIjyC8kh9DX 6CDinDBmYwqsDttHUfxnzmqXVfe4YPSOf2uPvOur0bpAjCpNMfgZV+i5g9LZEg== X-Migadu-Spam-Score: -6.06 X-Spam-Score: -6.06 X-Migadu-Queue-Id: DAC70301FF X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b="osgxB/WE"; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net X-TUID: U4nWkNdTOGzq Max Nikulin writes: > In emacs-26 `string-join' is defined in subr-x.el, but ox-texinfo.el > does not have (require 'subr-x). Personally I see nothing bad in > > (format "@displaymath\n%s\n@end" math-example) > > Historically subr-x was avoided in Org. Latest discussion: > https://list.orgmode.org/b1eef17f-b8ef-2e2a-d463-7909b03ce6eb@gmail.com/T/#u ... which concluded that it is safe to use subr-x. If we need to add a require, so be it. I see no major downsides. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at