emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Hugh Daschbach <hdasch@gmail.com>
From: Hugh Daschbach <hugh@ccss.com>
To: emacs-orgmode@gnu.org
Subject: [PATCH] Fix XEmacs "wrong type error" in org-export-as-pdf
Date: Sat, 20 Dec 2008 17:36:39 -0800	[thread overview]
Message-ID: <871vw2til4.fsf@gmail.com> (raw)

XEmacs throws a wrong-type-argument exception from org-export-as-pdf
if org file contains '&'.  See sample document, traceback, and patch
below.

This may well not be the best fix.  And it's not clear why this issue
doesn't exist in Emacs.  But there are several regular expressions in
org-export-latex-special-chars that call
org-export-latex-treat-backslash-char with a nil value for
string-after.  The regular expression that matched "MB&A" is
"\\(.\\|^\\)\\(&\\)".  So there is no (match-string 3).

Here's a document that generates the exception:

--8<---------------cut here---------------start------------->8---
* Header

MB&A

* Footer
--8<---------------cut here---------------end--------------->8---

Here's the traceback:

Debugger entered--Lisp error: (wrong-type-argument stringp nil)
  string-match("^[ \n	]" nil)
  (not (string-match "^[ \n	]" string-after))
  (and (not (string-match "^[ \n	]" string-after)) (not (string-match "[ 	]\\'\\|^" string-before)))
  (cond ((member ... org-html-entities) (concat string-before "$\\" ... "$")) ((and ... ...) (org-export-latex-protect-string ...)) ((not ...) (org-export-latex-protect-string ...)) ((and ... ...) (org-export-latex-protect-string ...)) (t (org-export-latex-protect-string ...)))
  org-export-latex-treat-backslash-char("B" nil)
  #<compiled-function (c) "...(304)" [sub-superscript match-data match-data match-data match-data c re-search-forward nil t get-text-property 2 org-protected match-string ("\\$" "$") "\\$" replace-match 1 "$" 3 ("&" "%" "#") "\\" "..." org-export-latex-protect-string "\\ldots{}" "~" 0 face org-link "\\~" "\\~{}" ("{" "}") match-data (...) org-inside-LaTeX-fragment-p (...) (...) org-export-latex-treat-backslash-char "" ("_" "^") (...) org-export-latex-treat-sub-super-char] 7>("\\(.\\|^\\)\\(&\\)")
  mapc-internal(#<compiled-function (c) "...(304)" [sub-superscript match-data match-data match-data match-data c re-search-forward nil t get-text-property 2 org-protected match-string ("\\$" "$") "\\$" replace-match 1 "$" 3 ("&" "%" "#") "\\" "..." org-export-latex-protect-string "\\ldots{}" "~" 0 face org-link "\\~" "\\~{}" ("{" "}") match-data (...) org-inside-LaTeX-fragment-p (...) (...) org-export-latex-treat-backslash-char "" ("_" "^") (...) org-export-latex-treat-sub-super-char] 7> ("^\\([^\n$]*?\\|^\\)\\(\\\\?\\$\\)\\([^\n$]*\\)$" "\\([a-za-z0-9]+\\|[ 	\n]\\|\\b\\|\\\\\\)\\(_\\|\\^\\)\\([a-za-z0-9]+\\|[ 	\n]\\|[:punct:]\\|{[a-za-z0-9]+}\\|([a-za-z0-9]+)\\)" "\\(.\\|^\\)\\(\\\\\\)\\([ 	\n]\\|[a-zA-Z&#%{}\"]+\\)" "\\(.\\|^\\)\\(&\\)" "\\(.\\|^\\)\\(#\\)" "\\(.\\|^\\)\\(%\\)" "\\(.\\|
 ^\\)\\({\\)" "\\(.\\|^\\)\\(}\\)" "\\(.\\|^\\)\\(~\\)" "\\(.\\|^\\)\\(\\.\\.\\.\\)"))
  mapc(#<compiled-function (c) "...(304)" [sub-superscript match-data match-data match-data match-data c re-search-forward nil t get-text-property 2 org-protected match-string ("\\$" "$") "\\$" replace-match 1 "$" 3 ("&" "%" "#") "\\" "..." org-export-latex-protect-string "\\ldots{}" "~" 0 face org-link "\\~" "\\~{}" ("{" "}") match-data (...) org-inside-LaTeX-fragment-p (...) (...) org-export-latex-treat-backslash-char "" ("_" "^") (...) org-export-latex-treat-sub-super-char] 7> ("^\\([^\n$]*?\\|^\\)\\(\\\\?\\$\\)\\([^\n$]*\\)$" "\\([a-za-z0-9]+\\|[ 	\n]\\|\\b\\|\\\\\\)\\(_\\|\\^\\)\\([a-za-z0-9]+\\|[ 	\n]\\|[:punct:]\\|{[a-za-z0-9]+}\\|([a-za-z0-9]+)\\)" "\\(.\\|^\\)\\(\\\\\\)\\([ 	\n]\\|[a-zA-Z&#%{}\"]+\\)" "\\(.\\|^\\)\\(&\\)" "\\(.\\|^\\)\\(#\\)" "\\(.\\|^\\)\\(%\\)" "\\(.\\|^\\)\\({\
 \)" "\\(.\\|^\\)\\(}\\)" "\\(.\\|^\\)\\(~\\)" "\\(.\\|^\\)\\(\\.\\.\\.\\)"))
  org-export-latex-special-chars(t)
  org-export-latex-content("\nMB&A\n\n")
  org-export-latex-first-lines(nil)
  org-export-as-latex(nil nil nil nil nil nil)
  org-export-as-pdf(nil)
  call-interactively(org-export-as-pdf)
  command-execute(org-export-as-pdf t)
  execute-extended-command(nil)
  call-interactively(execute-extended-command)
---
 lisp/org-export-latex.el |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/lisp/org-export-latex.el b/lisp/org-export-latex.el
index fa6a0e4..60795fb 100644
--- a/lisp/org-export-latex.el
+++ b/lisp/org-export-latex.el
@@ -976,6 +976,7 @@ The conversion is made depending of STRING-BEFORE and STRING-AFTER."
 	 (concat string-before "$\\"
 		 (or (cdar (member (list string-after) org-html-entities))
 		     string-after) "$"))
+	((null string-after) (concat string-before "\\"))
 	((and (not (string-match "^[ \n\t]" string-after))
 	      (not (string-match "[ \t]\\'\\|^" string-before)))
 	 ;; backslash is inside a word
-- 
1.5.6.3

             reply	other threads:[~2008-12-21  2:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-21  1:36 Hugh Daschbach, Hugh Daschbach [this message]
2008-12-21 11:49 ` [PATCH] Fix XEmacs "wrong type error" in org-export-as-pdf Carsten Dominik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871vw2til4.fsf@gmail.com \
    --to=hdasch@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).