From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Maus Subject: Re: Re[6]: programming for org-mode Date: Mon, 09 Aug 2010 21:16:06 +0200 Message-ID: <871va78umh.wl%dmaus@ictsoc.de> References: <3910304564.20100715085202@gmail.com> <87vd8gejvk.fsf@gmail.com> <226505391.20100805163301@gmail.com> <87lj8ia7nj.wl%dmaus@ictsoc.de> <510683939.20100807192935@gmail.com> <87mxsxvc3o.wl%dmaus@ictsoc.de> <1245668073.20100808194925@gmail.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: multipart/mixed; boundary="===============1408663278==" Return-path: Received: from [140.186.70.92] (port=33841 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OiXpn-00072Z-BF for emacs-orgmode@gnu.org; Mon, 09 Aug 2010 15:16:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OiXpm-0006Wu-18 for emacs-orgmode@gnu.org; Mon, 09 Aug 2010 15:16:31 -0400 Received: from mysql1.xlhost.de ([213.202.242.106]:35550) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OiXpl-0006We-Sa for emacs-orgmode@gnu.org; Mon, 09 Aug 2010 15:16:29 -0400 In-Reply-To: <1245668073.20100808194925@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Ivanov Dmitry Cc: emacs-orgmode@gnu.org --===============1408663278== Content-Type: multipart/signed; boundary="pgp-sign-Multipart_Mon_Aug__9_21:16:06_2010-1"; micalg=pgp-sha256; protocol="application/pgp-signature" Content-Transfer-Encoding: 7bit --pgp-sign-Multipart_Mon_Aug__9_21:16:06_2010-1 Content-Type: text/plain; charset=US-ASCII Ivanov Dmitry wrote: >I modified the scheme and the function. I think, that these 2 if-s >just complicate the code for comprehension: we have 3 cases, for each >of them we should return the appropriate value. Yes, `cond' is more suitable here. >All the tests work fine with the new version. >When I tried >(org-read-prop "(1 2 3))") -> (1 2 3) >It gave me (1 2 3), ignoring the last ')'. Seems to be the read >function bug. Not sure if it is a bug or the indended behavior. `read' returns the first valid lisp expression in finds. E.g. (read "(a b c) foo bar") => (a b c) I think this is good enough at this place. A complete solutation would require to parse the entire string. >At last I got rid of these nasty little squares on the scheme :) :D Of course the next step for you would be to tame the beast called git and prepare a proper patch. The steps are: 1. create a topic branch for the fix 2. change the function, commit to topic branch and provide a proper commit message (http://orgmode.org/worg/org-contribute.php#sec-4) 3. create a patch against current master 4. send the patch manually or using git send-email Best, -- David -- OpenPGP... 0x99ADB83B5A4478E6 Jabber.... dmjena@jabber.org Email..... dmaus@ictsoc.de --pgp-sign-Multipart_Mon_Aug__9_21:16:06_2010-1 Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iF4EABEIAAYFAkxgU/YACgkQma24O1pEeObBCgD+KegbFFFVCDdTGH578dbJOd0b SydDW9lEUn6Ki7AkDFgA/jOAxh3AOcBs5fhzZt03Iwp4hTtcAGQJcvBDY4pw4sM+ =IzBM -----END PGP SIGNATURE----- --pgp-sign-Multipart_Mon_Aug__9_21:16:06_2010-1-- --===============1408663278== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Emacs-orgmode mailing list Please use `Reply All' to send replies to the list. Emacs-orgmode@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-orgmode --===============1408663278==--