Ivanov Dmitry wrote: >I modified the scheme and the function. I think, that these 2 if-s >just complicate the code for comprehension: we have 3 cases, for each >of them we should return the appropriate value. Yes, `cond' is more suitable here. >All the tests work fine with the new version. >When I tried >(org-read-prop "(1 2 3))") -> (1 2 3) >It gave me (1 2 3), ignoring the last ')'. Seems to be the read >function bug. Not sure if it is a bug or the indended behavior. `read' returns the first valid lisp expression in finds. E.g. (read "(a b c) foo bar") => (a b c) I think this is good enough at this place. A complete solutation would require to parse the entire string. >At last I got rid of these nasty little squares on the scheme :) :D Of course the next step for you would be to tame the beast called git and prepare a proper patch. The steps are: 1. create a topic branch for the fix 2. change the function, commit to topic branch and provide a proper commit message (http://orgmode.org/worg/org-contribute.php#sec-4) 3. create a patch against current master 4. send the patch manually or using git send-email Best, -- David -- OpenPGP... 0x99ADB83B5A4478E6 Jabber.... dmjena@jabber.org Email..... dmaus@ictsoc.de