Re: Re[6]: programming for org-mode

From: David Maus <dmaus@ictsoc.de>
To: Ivanov Dmitry <usr345@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Re[6]: programming for org-mode
Date: Mon, 09 Aug 2010 21:16:06 +0200	[thread overview]
Message-ID: <871va78umh.wl%dmaus@ictsoc.de> (raw)
In-Reply-To: <1245668073.20100808194925@gmail.com>

[-- Attachment #1.1: Type: text/plain, Size: 1262 bytes --]

Ivanov Dmitry wrote:

>I modified the scheme and the function. I think, that these 2 if-s
>just complicate the code for comprehension: we have 3 cases, for each
>of them we should return the appropriate value.

Yes, `cond' is more suitable here.

>All the tests work fine with the new version.
>When I tried

>(org-read-prop "(1 2 3))") -> (1 2 3)

>It gave me (1 2 3), ignoring the last ')'. Seems to be the read
>function bug.

Not sure if it is a bug or the indended behavior.  `read' returns the
first valid lisp expression in finds.  E.g.

(read "(a b c) foo bar") => (a b c)

I think this is good enough at this place.  A complete solutation
would require to parse the entire string.

>At last I got rid of these nasty little squares on the scheme :)

:D

Of course the next step for you would be to tame the beast called git
and prepare a proper patch.  The steps are:

 1. create a topic branch for the fix

 2. change the function, commit to topic branch and provide a proper
    commit message
    (http://orgmode.org/worg/org-contribute.php#sec-4)

 3. create a patch against current master

 4. send the patch manually or using git send-email

Best,
  -- David
--
OpenPGP... 0x99ADB83B5A4478E6
Jabber.... dmjena@jabber.org
Email..... dmaus@ictsoc.de

[-- Attachment #1.2: Type: application/pgp-signature, Size: 230 bytes --]

[-- Attachment #2: Type: text/plain, Size: 201 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode