From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sebastian Rose Subject: Re: [PATCH] Re: [bug] org-link-escape and (wrong-type-argument stringp nil) Date: Mon, 27 Sep 2010 14:43:22 +0200 Message-ID: <871v8fgxw5.fsf@gmx.de> References: <8739swi0f0.fsf@gmx.de> <1285565761-7558-1-git-send-email-dmaus@ictsoc.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from [140.186.70.92] (port=54772 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P0D3L-0005g4-0T for emacs-orgmode@gnu.org; Mon, 27 Sep 2010 08:43:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1P0D3J-0001Pu-HP for emacs-orgmode@gnu.org; Mon, 27 Sep 2010 08:43:30 -0400 Received: from mailout-de.gmx.net ([213.165.64.22]:33344 helo=mail.gmx.net) by eggs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1P0D3J-0001PZ-4c for emacs-orgmode@gnu.org; Mon, 27 Sep 2010 08:43:29 -0400 In-Reply-To: <1285565761-7558-1-git-send-email-dmaus@ictsoc.de> (David Maus's message of "Mon, 27 Sep 2010 07:36:00 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: David Maus Cc: emacs-orgmode@gnu.org David Maus writes: >> Also I guess the decoding is secure. Means we could change the >> comment of this function: > >> (defun org-protocol-unhex-compound (hex) >> "Unhexify unicode hex-chars. E.g. `%C3%B6' is the German Umlaut `=C3= =B6'. >> Note: this function falls back on single byte decoding if a >> character sequence is not valid utf-8. >> See `org-protocol-unhex-single-byte-sequence'." > > >> Should I send another patch against master? (Too late here... for >> me...) > > Not necessary, following patch removed this sentence and added a > proper commit message (please see: Commit messages and ChangeLog > entries on http://orgmode.org/worg/org-contribute.php). > > I took the new patch "under review" in patchtracker -- If someone else > wants to jump on it, just go ahead. > > Best, > -- David Thanks David! Sebastian