* [dev] Reduce warnings on org-contacs compilation
@ 2011-06-27 19:11 Michael Markert
2011-06-27 20:44 ` Julien Danjou
0 siblings, 1 reply; 2+ messages in thread
From: Michael Markert @ 2011-06-27 19:11 UTC (permalink / raw)
To: emacs-orgmode, Julien Danjou
[-- Attachment #1.1: Type: text/plain, Size: 140 bytes --]
Hi,
I noticed two easily fixable compile warnings. The first one tackles the
wl code and the second includes cl on compilation.
Michael
[-- Attachment #1.2: 0001-org-contacts-Use-with-current-buffer-instead-of-save.patch --]
[-- Type: text/plain, Size: 1277 bytes --]
From 057b14ebe412a6085b5ba61559211d1d2402c16b Mon Sep 17 00:00:00 2001
Message-Id: <057b14ebe412a6085b5ba61559211d1d2402c16b.1309198827.git.markert.michael@googlemail.com>
From: Michael Markert <markert.michael@googlemail.com>
Date: Mon, 27 Jun 2011 20:17:53 +0200
Subject: [PATCH 1/2] org-contacts: Use `with-current-buffer' instead of
`save-excursion'+`with-current-buffer'.
To: emacs-orgmode@gnu.org
Signed-off-by: Michael Markert <markert.michael@googlemail.com>
---
contrib/lisp/org-contacts.el | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/contrib/lisp/org-contacts.el b/contrib/lisp/org-contacts.el
index 63ba005..9b08d67 100644
--- a/contrib/lisp/org-contacts.el
+++ b/contrib/lisp/org-contacts.el
@@ -418,8 +418,7 @@ This adds `org-contacts-gnus-check-mail-address' and
"Retrieve the content of the `From' header of an email.
Works from wl-summary-mode and mime-view-mode - that is while viewing email.
Depends on Wanderlust been loaded."
- (save-excursion
- (set-buffer (org-capture-get :original-buffer))
+ (with-current-buffer (org-capture-get :original-buffer)
(cond
((eq major-mode 'wl-summary-mode) (when wl-summary-buffer-elmo-folder
(elmo-message-field
--
1.7.5.4
[-- Attachment #1.3: 0002-org-contacts-Require-cl-on-compilation.patch --]
[-- Type: text/plain, Size: 1014 bytes --]
From 31c1d3a859b5aeb6bb12b68a86c30b8454c7b39c Mon Sep 17 00:00:00 2001
Message-Id: <31c1d3a859b5aeb6bb12b68a86c30b8454c7b39c.1309198827.git.markert.michael@googlemail.com>
In-Reply-To: <057b14ebe412a6085b5ba61559211d1d2402c16b.1309198827.git.markert.michael@googlemail.com>
References: <057b14ebe412a6085b5ba61559211d1d2402c16b.1309198827.git.markert.michael@googlemail.com>
From: Michael Markert <markert.michael@googlemail.com>
Date: Mon, 27 Jun 2011 20:19:23 +0200
Subject: [PATCH 2/2] org-contacts: Require cl on compilation.
To: emacs-orgmode@gnu.org
Signed-off-by: Michael Markert <markert.michael@googlemail.com>
---
contrib/lisp/org-contacts.el | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/contrib/lisp/org-contacts.el b/contrib/lisp/org-contacts.el
index 9b08d67..f846fe2 100644
--- a/contrib/lisp/org-contacts.el
+++ b/contrib/lisp/org-contacts.el
@@ -36,6 +36,9 @@
;;
;;; Code:
+(eval-when-compile
+ (require 'cl))
+
(eval-and-compile
(require 'org))
--
1.7.5.4
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-06-27 20:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-06-27 19:11 [dev] Reduce warnings on org-contacs compilation Michael Markert
2011-06-27 20:44 ` Julien Danjou
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).