From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Markert Subject: [dev] Reduce warnings on org-contacs compilation Date: Mon, 27 Jun 2011 21:11:23 +0200 Message-ID: <871uyf9jj8.wl%markert.michael@googlemail.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: multipart/signed; boundary="pgp-sign-Multipart_Mon_Jun_27_21:11:23_2011-1"; micalg=pgp-sha256; protocol="application/pgp-signature" Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([140.186.70.92]:37994) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QbHDW-0006cy-4e for emacs-orgmode@gnu.org; Mon, 27 Jun 2011 15:11:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QbHDU-0003Tu-60 for emacs-orgmode@gnu.org; Mon, 27 Jun 2011 15:11:29 -0400 Received: from mail-fx0-f52.google.com ([209.85.161.52]:40077) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QbHDT-0003OK-Hs for emacs-orgmode@gnu.org; Mon, 27 Jun 2011 15:11:27 -0400 Received: by fxd18 with SMTP id 18so1906677fxd.39 for ; Mon, 27 Jun 2011 12:11:26 -0700 (PDT) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org, Julien Danjou --pgp-sign-Multipart_Mon_Jun_27_21:11:23_2011-1 Content-Type: multipart/mixed; boundary="Multipart_Mon_Jun_27_21:11:23_2011-1" --Multipart_Mon_Jun_27_21:11:23_2011-1 Content-Type: text/plain; charset=US-ASCII Hi, I noticed two easily fixable compile warnings. The first one tackles the wl code and the second includes cl on compilation. Michael --Multipart_Mon_Jun_27_21:11:23_2011-1 Content-Type: text/plain; type=patch; charset=US-ASCII Content-Disposition: attachment; filename="0001-org-contacts-Use-with-current-buffer-instead-of-save.patch" Content-Transfer-Encoding: 7bit >From 057b14ebe412a6085b5ba61559211d1d2402c16b Mon Sep 17 00:00:00 2001 Message-Id: <057b14ebe412a6085b5ba61559211d1d2402c16b.1309198827.git.markert.michael@googlemail.com> From: Michael Markert Date: Mon, 27 Jun 2011 20:17:53 +0200 Subject: [PATCH 1/2] org-contacts: Use `with-current-buffer' instead of `save-excursion'+`with-current-buffer'. To: emacs-orgmode@gnu.org Signed-off-by: Michael Markert --- contrib/lisp/org-contacts.el | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/contrib/lisp/org-contacts.el b/contrib/lisp/org-contacts.el index 63ba005..9b08d67 100644 --- a/contrib/lisp/org-contacts.el +++ b/contrib/lisp/org-contacts.el @@ -418,8 +418,7 @@ This adds `org-contacts-gnus-check-mail-address' and "Retrieve the content of the `From' header of an email. Works from wl-summary-mode and mime-view-mode - that is while viewing email. Depends on Wanderlust been loaded." - (save-excursion - (set-buffer (org-capture-get :original-buffer)) + (with-current-buffer (org-capture-get :original-buffer) (cond ((eq major-mode 'wl-summary-mode) (when wl-summary-buffer-elmo-folder (elmo-message-field -- 1.7.5.4 --Multipart_Mon_Jun_27_21:11:23_2011-1 Content-Type: text/plain; type=patch; charset=US-ASCII Content-Disposition: attachment; filename="0002-org-contacts-Require-cl-on-compilation.patch" Content-Transfer-Encoding: 7bit >From 31c1d3a859b5aeb6bb12b68a86c30b8454c7b39c Mon Sep 17 00:00:00 2001 Message-Id: <31c1d3a859b5aeb6bb12b68a86c30b8454c7b39c.1309198827.git.markert.michael@googlemail.com> In-Reply-To: <057b14ebe412a6085b5ba61559211d1d2402c16b.1309198827.git.markert.michael@googlemail.com> References: <057b14ebe412a6085b5ba61559211d1d2402c16b.1309198827.git.markert.michael@googlemail.com> From: Michael Markert Date: Mon, 27 Jun 2011 20:19:23 +0200 Subject: [PATCH 2/2] org-contacts: Require cl on compilation. To: emacs-orgmode@gnu.org Signed-off-by: Michael Markert --- contrib/lisp/org-contacts.el | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/contrib/lisp/org-contacts.el b/contrib/lisp/org-contacts.el index 9b08d67..f846fe2 100644 --- a/contrib/lisp/org-contacts.el +++ b/contrib/lisp/org-contacts.el @@ -36,6 +36,9 @@ ;; ;;; Code: +(eval-when-compile + (require 'cl)) + (eval-and-compile (require 'org)) -- 1.7.5.4 --Multipart_Mon_Jun_27_21:11:23_2011-1-- --pgp-sign-Multipart_Mon_Jun_27_21:11:23_2011-1 Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBCAAGBQJOCNXbAAoJEHHMVUK0UjKVEG4QAI0g0ZA2BYMP1zi1sveGFH/X mEv4XQMdcYzDG3KT4v/EF550k+LaPzBvKmXvZ2kx0NccJpFrPkm1/7r1tLBghVAa ubIhUCGXMVnt1extBo2kpAlkzzflh+1AeDFFUbmsFWXt4xJf4utX2mXXPVTqpc2+ bCfEnJH09L2IrnNwKdZh4ft+BSrfBWFq7LreAOVT3Zwdr3YQsHY6LzKbj3OmM9+P 1kpnWv6/+Mj+iBqNCPNk9P69TI4cZgYijC8O8XTDBoOO/VGaE/M3mbK5Oqjndd2w Y9ziY8oi/hBMrzJamTA6Zf/MIqvIHOlAzn29VnvlnF4DUS9NtXj+pzBZl1v1AiGY WnvbxQS3uuZ+EvAFC6CCExtAf89CbpPpjfLvMzSMicxl2pcFcQ5eWZk84POyVLT+ 3duo+V6elpr3f0OdNsiRs3WG5oGIJ7A1hrZK9Xo6v8DD2hCqC3FDmKjEmoRWKDYO TtfZd6sQ49pT+bVWQ9U/cTkEviPu7x5mKfA5Lp8J2WdM5nhhnfD93z1b8jfqVW+5 jv1Mq2NIPa+lYNc7oLEpQVa+43l38uHZhFShLx4XRLk6rZYO9RsDyi64OfU+RclF ll3p9dw2ZvJES8EMwipk7sOHYOm6DW5iGfBh6M5c0beaIJ8IFDuGUCZv5RNEUB57 EBpaX/p/FHmGkr2UnKOX =KCUE -----END PGP SIGNATURE----- --pgp-sign-Multipart_Mon_Jun_27_21:11:23_2011-1--