From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Maus Subject: [PATCH] Escape link path only if path contains space or non-ascii character Date: Sun, 18 Dec 2011 19:31:14 +0100 Message-ID: <871us1lojx.wl%dmaus@ictsoc.de> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: multipart/signed; boundary="pgp-sign-Multipart_Sun_Dec_18_19:31:14_2011-1"; micalg=pgp-sha256; protocol="application/pgp-signature" Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([140.186.70.92]:40439) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RcLW4-0005XC-6h for emacs-orgmode@gnu.org; Sun, 18 Dec 2011 13:31:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RcLW2-0000KF-Pf for emacs-orgmode@gnu.org; Sun, 18 Dec 2011 13:31:20 -0500 Received: from app1a.xlhost.de ([213.202.242.161]:53290) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RcLW2-0000KB-Hz for emacs-orgmode@gnu.org; Sun, 18 Dec 2011 13:31:18 -0500 Received: from x60s.ictsoc.de.ictsoc.de (p5485B4C3.dip.t-dialin.net [84.133.180.195]) (Authenticated sender: dmaus@ictsoc.de) by app1a.xlhost.de (Postfix) with ESMTPSA id 62F6B11B2CA3 for ; Sun, 18 Dec 2011 19:31:16 +0100 (CET) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org --pgp-sign-Multipart_Sun_Dec_18_19:31:14_2011-1 Content-Type: multipart/mixed; boundary="Multipart_Sun_Dec_18_19:31:14_2011-1" --Multipart_Sun_Dec_18_19:31:14_2011-1 Content-Type: text/plain; charset=US-ASCII Hi there, Attached patch should take care of mistakenly double-escaped links as reported by Jeff Horn in . This patch might break `org-open-at-point' for some users if the target application does not deal with (possibly) unescaped URLs. The alternative to the guesswork would require parsing und analyzing the link and its components (path, query, fragment) and check for characters that absolutely need escaping depeding on the link type. Hopefully this solution is good enough. Best, -- David --Multipart_Sun_Dec_18_19:31:14_2011-1 Content-Type: text/plain; type=patch; charset=US-ASCII Content-Disposition: attachment; filename="0001-Escape-link-path-only-if-path-contains-space-or-non-.patch" Content-Transfer-Encoding: base64 RnJvbSBkZGI0NjEzMjY4OTY4MjVkY2U2ZmQ1OGJmZDllNGVhMjVhM2EzNWZmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEYXZpZCBNYXVzIDxkbWF1c0BpY3Rzb2MuZGU+CkRhdGU6IFN1 biwgMTggRGVjIDIwMTEgMTk6MjM6NTcgKzAxMDAKU3ViamVjdDogW1BBVENIXSBFc2NhcGUgbGlu ayBwYXRoIG9ubHkgaWYgcGF0aCBjb250YWlucyBzcGFjZSBvciBub24tYXNjaWkgY2hhcmFjdGVy CgoqIG9yZy5lbCAob3JnLW9wZW4tYXQtcG9pbnQpOiBFc2NhcGUgbGluayBwYXRoIGZvciBodHRw OiwgaHR0cHM6LApmdHA6LCBuZXdzOiwgYW5kIGRvaTogbGlua3Mgb25seSBpZiB0aGUgcGF0aCBj b250YWlucyBzcGFjZSBvcgpub24tYXNjaWkgY2hhcmFjdGVyLgoKVGhpcyBzaG91bGQgdGFrZSBj YXJlIG9mIG1pc3Rha2VubHkgZG91YmxlLWVzY2FwZWQgbGlua3MgYXMgcmVwb3J0ZWQKYnkgSmVm ZiBIb3JuIGluIDxodHRwOi8vYXJ0aWNsZS5nbWFuZS5vcmcvZ21hbmUuZW1hY3Mub3JnbW9kZS80 ODczMT4uCgpXZSBhcmUganVzdCBndWVzc2luZyBoZXJlIGFuZCBwdXNoIHRoZSByZXNwb25zaWJp bGl0eSBmb3IgcHJvcGVyCmVzY2FwaW5nIHRvIHRoZSB0YXJnZXQgYXBwbGljYXRpb24uCi0tLQog bGlzcC9vcmcuZWwgfCAgIDEzICsrKysrKysrLS0tLS0KIDEgZmlsZXMgY2hhbmdlZCwgOCBpbnNl cnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3Avb3JnLmVsIGIvbGlz cC9vcmcuZWwKaW5kZXggOGExZmJkMy4uMTI3NGYyNCAxMDA2NDQKLS0tIGEvbGlzcC9vcmcuZWwK KysrIGIvbGlzcC9vcmcuZWwKQEAgLTk1NjksMTMgKzk1NjksMTYgQEAgYXBwbGljYXRpb24gdGhl IHN5c3RlbSB1c2VzIGZvciB0aGlzIGZpbGUgdHlwZS4iCiAJICAgIChhcHBseSBjbWQgKG5yZXZl cnNlIGFyZ3MxKSkpKQogCiAJICgobWVtYmVyIHR5cGUgJygiaHR0cCIgImh0dHBzIiAiZnRwIiAi bmV3cyIpKQotCSAgKGJyb3dzZS11cmwgKGNvbmNhdCB0eXBlICI6IiAob3JnLWxpbmstZXNjYXBl Ci0JCQkJCXBhdGggb3JnLWxpbmstZXNjYXBlLWNoYXJzLWJyb3dzZXIpKSkpCisJICAoYnJvd3Nl LXVybCAoY29uY2F0IHR5cGUgIjoiIChpZiAob3JnLXN0cmluZy1tYXRjaC1wICJbWzpub25hc2Np aTpdIF0iIHBhdGgpCisJCQkJCSAgIChvcmctbGluay1lc2NhcGUKKwkJCQkJICAgIHBhdGggb3Jn LWxpbmstZXNjYXBlLWNoYXJzLWJyb3dzZXIpCisJCQkJCSBwYXRoKSkpKQogCiAJICgoc3RyaW5n PSB0eXBlICJkb2kiKQotCSAgKGJyb3dzZS11cmwgKGNvbmNhdCAiaHR0cDovL2R4LmRvaS5vcmcv IgotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKG9yZy1saW5rLWVzY2FwZQotICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIHBhdGggb3JnLWxpbmstZXNjYXBlLWNoYXJzLWJyb3dz ZXIpKSkpCisJICAoYnJvd3NlLXVybCAoY29uY2F0ICJodHRwOi8vZHguZG9pLm9yZy8iIChpZiAo b3JnLXN0cmluZy1tYXRjaC1wICJbWzpub25hc2NpaTpdIF0iIHBhdGgpCisJCQkJCQkgICAgICAg KG9yZy1saW5rLWVzY2FwZQorCQkJCQkJCXBhdGggb3JnLWxpbmstZXNjYXBlLWNoYXJzLWJyb3dz ZXIpCisJCQkJCQkgICAgIHBhdGgpKSkpCiAKIAkgKChtZW1iZXIgdHlwZSAnKCJtZXNzYWdlIikp CiAJICAoYnJvd3NlLXVybCAoY29uY2F0IHR5cGUgIjoiIHBhdGgpKSkKLS0gCjEuNy4yLjUKCg== --Multipart_Sun_Dec_18_19:31:14_2011-1-- --pgp-sign-Multipart_Sun_Dec_18_19:31:14_2011-1 Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iF4EABEIAAYFAk7uMXIACgkQma24O1pEeOaEpgD+IsGJH0OzNNgMU49qG6AVulzL bxwqXl9O0fmLYRUozfkBALU2N6PzUeCJKeyDinOY7AGjCrWFPazV2NsWkxg5dZnm =0qKI -----END PGP SIGNATURE----- --pgp-sign-Multipart_Sun_Dec_18_19:31:14_2011-1--