emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* e-beamer-patch
@ 2012-08-22 12:39 Philipp Kroos
  2012-08-22 14:35 ` e-beamer-patch Nicolas Goaziou
  0 siblings, 1 reply; 2+ messages in thread
From: Philipp Kroos @ 2012-08-22 12:39 UTC (permalink / raw)
  To: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 383 bytes --]

Hi,

while trying the new e-beamer I ran into a type-error which occurs when 
org-e-beamer-outline-frame-options is left at its default value `nil'.

The attached patch is a possible solution that works for me, though a 
more general check in org-e-beamer--normalize-arguments may be more 
appropriate (in case I'm not just missing to set a certain option 
right).

Regards,
Philipp

[-- Attachment #2: 0001-e-beamer-Fix-a-type-error-with-normalize-argument.patch --]
[-- Type: text/plain, Size: 1263 bytes --]

From 9514f0b3b63659df676b72442283c8b43cfbcadb Mon Sep 17 00:00:00 2001
From: Philipp Kroos <philipp.kroos@t-online.de>
Date: Wed, 22 Aug 2012 14:25:20 +0200
Subject: [PATCH] e-beamer: Fix a type-error with normalize-argument

* org-e-beamer.el (org-e-beamer-template): Make sure
`org-e-beamer--normalize-argument' is not called with `nil'
when formatting the toc.

The error occured when org-e-beamer-outline-frame-options
has got no value (the default).
---
 contrib/lisp/org-e-beamer.el | 6 ++++--
 1 Datei geändert, 4 Zeilen hinzugefügt(+), 2 Zeilen entfernt(-)

diff --git a/contrib/lisp/org-e-beamer.el b/contrib/lisp/org-e-beamer.el
index af5b8ff..9096531 100644
--- a/contrib/lisp/org-e-beamer.el
+++ b/contrib/lisp/org-e-beamer.el
@@ -815,8 +815,10 @@ holding export options."
        (when depth
 	 (concat
 	  (format "\\begin{frame}%s{%s}\n"
-		  (org-e-beamer--normalize-argument
-		   org-e-beamer-outline-frame-options 'option)
+		  (if org-e-beamer-outline-frame-options
+		      (org-e-beamer--normalize-argument
+		       org-e-beamer-outline-frame-options 'option)
+		    "")
 		  org-e-beamer-outline-frame-title)
 	  (when (wholenump depth)
 	    (format "\\setcounter{tocdepth}{%d}\n" depth))
-- 
1.7.11.4


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: e-beamer-patch
  2012-08-22 12:39 e-beamer-patch Philipp Kroos
@ 2012-08-22 14:35 ` Nicolas Goaziou
  0 siblings, 0 replies; 2+ messages in thread
From: Nicolas Goaziou @ 2012-08-22 14:35 UTC (permalink / raw)
  To: Philipp Kroos; +Cc: emacs-orgmode

Hello,

Philipp Kroos <Philipp.Kroos@t-online.de> writes:

> while trying the new e-beamer I ran into a type-error which occurs when 
> org-e-beamer-outline-frame-options is left at its default value `nil'.
>
> The attached patch is a possible solution that works for me, though a 
> more general check in org-e-beamer--normalize-arguments may be more 
> appropriate (in case I'm not just missing to set a certain option 
> right).

Since the type of `org-e-beamer-outline-frame-options' is a string, I've
changed its default value to the empty string. That should solve the
problem.

Thank you for reporting this.


Regards,

-- 
Nicolas Goaziou

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-08-22 14:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-08-22 12:39 e-beamer-patch Philipp Kroos
2012-08-22 14:35 ` e-beamer-patch Nicolas Goaziou

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).