emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* Org clock markers are not consistent with org-clock-history
@ 2013-04-23 18:06 Bernt Hansen
  2013-04-24  8:48 ` Bastien
  0 siblings, 1 reply; 3+ messages in thread
From: Bernt Hansen @ 2013-04-23 18:06 UTC (permalink / raw)
  To: Bastien; +Cc: emacs-orgmode, carsten.dominik

Hi Bastien,

My workflow has been slightly broken since this commit:

,----
| commit 796b4ec43bef813fc482ca996e8dc2ee3f09200a
| Author: Bastien Guerry <bzg@altern.org>
| Date:   Fri Jul 27 17:24:16 2012 +0200
| 
|      org-clock.el: Set the marker for `org-clock-history' at a safer
|      position.
| 
|     * org-clock.el (org-clock-in): Set the marker for
|     `org-clock-history' at a safer position.
| 
|     The clock marker stored in `org-clock-history' used to be at the
|     beginning of the heading.  When manually inserting content here,
|     the marker is not updated because it is *before* the point.  So
|     set the clock marker right after the first "*" of the headline
|     so that it will always be correctly updated.
`----

This moves the marker for org-clock-history forwards by one character so
it's no longer possible to easily check if the org-clock-default-task or
org-clock-interrupted-task is the same as the marker in the history
list.

I have a function bound to F9-SPC which skips back to the previously
clocked task and it used to skip over the default task ... but this no
longer works because the marker in history no longer matches the default
task.  This has been broken for a long time (since July) but I just now
spent the time to figure out exactly why.

The markers and history used to be consistent and this is no longer the
case.  Can the other markers also be moved forward one char to match the
history marker or do I need to modify my function to compute a new
marker so I can compare it with what is in the clock history?

Shouldn't ALL clock markers be treated the same way? (Either move them
all forward or none of them)

Thanks,
Bernt

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Org clock markers are not consistent with org-clock-history
  2013-04-23 18:06 Org clock markers are not consistent with org-clock-history Bernt Hansen
@ 2013-04-24  8:48 ` Bastien
  2013-04-24 14:19   ` Bernt Hansen
  0 siblings, 1 reply; 3+ messages in thread
From: Bastien @ 2013-04-24  8:48 UTC (permalink / raw)
  To: Bernt Hansen; +Cc: emacs-orgmode, carsten.dominik

Hi Bernt,

Bernt Hansen <bernt@norang.ca> writes:

> Shouldn't ALL clock markers be treated the same way?

Definitely.

> (Either move them all forward or none of them)

I removed the forward char ugly hack--I cannot reproduce the
error I was seeing before when the user manually inserts some
text right on the marker and modifies it in the wrong direction.

I will try to reproduce the problem later on, but lets use the
clean way for now.

Thanks!

-- 
 Bastien

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Org clock markers are not consistent with org-clock-history
  2013-04-24  8:48 ` Bastien
@ 2013-04-24 14:19   ` Bernt Hansen
  0 siblings, 0 replies; 3+ messages in thread
From: Bernt Hansen @ 2013-04-24 14:19 UTC (permalink / raw)
  To: Bastien; +Cc: emacs-orgmode, carsten.dominik

Bastien <bzg@gnu.org> writes:

> I removed the forward char ugly hack--I cannot reproduce the
> error I was seeing before when the user manually inserts some
> text right on the marker and modifies it in the wrong direction.
>
> I will try to reproduce the problem later on, but lets use the
> clean way for now.
>
> Thanks!

Thanks!  Works for me again :)

Regards,
Bernt

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-04-24 14:19 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-04-23 18:06 Org clock markers are not consistent with org-clock-history Bernt Hansen
2013-04-24  8:48 ` Bastien
2013-04-24 14:19   ` Bernt Hansen

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).