emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <n.goaziou@gmail.com>
To: Bastien <bzg@altern.org>
Cc: emacs-orgmode@gnu.org, Carsten Dominik <carsten.dominik@gmail.com>
Subject: Re: M-RET slow
Date: Fri, 26 Apr 2013 17:24:19 +0200	[thread overview]
Message-ID: <871u9x71ss.fsf@gmail.com> (raw)
In-Reply-To: <87k3nptj1w.fsf@bzg.ath.cx> (Bastien's message of "Fri, 26 Apr 2013 17:20:43 +0200")

Bastien <bzg@altern.org> writes:

> Hi Nicolas,
>
> Nicolas Goaziou <n.goaziou@gmail.com> writes:
>
>> Hello,
>>
>> Bastien <bzg@altern.org> writes:
>>
>>> Carsten Dominik <carsten.dominik@gmail.com> writes:
>>>
>>>> is org-in-item-p slow?
>>>
>>> It depends on the size of the list -- see for example this problem,
>>> where moving an item within a logbook drawer with many items is too
>>> slow:
>>>
>>> http://thread.gmane.org/gmane.emacs.orgmode/66574
>>
>> This is a different issue. `org-move-item-down' doesn't use
>> `org-in-item-p'. The bottleneck here is, without surprise,
>> `org-list-struct', as explained in the comments at the beginning of
>> "org-list.el".
>
> I see.  `org-at-item-p' is less expensive than `org-in-item-p' but 
> still very expensive as it calls `org-list-in-valid-context-p'.

"very expensive" is a bit harsh, at it doesn't depend on the size of the
list. Anyway, ultimately, `org-at-item-p' and `org-in-item-p' should be
replaced by `org-element-at-point'.

Then, all speed-up efforts should concentrate on that function (e.g.,
caching).


Regards,

-- 
Nicolas Goaziou

  reply	other threads:[~2013-04-26 15:24 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-25 19:01 Samuel Wales
2013-04-26  6:39 ` Bastien
2013-04-26 14:18   ` Nicolas Goaziou
2013-04-26 14:33     ` Carsten Dominik
2013-04-26 14:41       ` Bastien
2013-04-26 14:50         ` Nicolas Goaziou
2013-04-26 15:20           ` Bastien
2013-04-26 15:24             ` Nicolas Goaziou [this message]
2013-04-26 14:46       ` Nicolas Goaziou
2013-04-26 14:51         ` Carsten Dominik
2013-04-26 14:57           ` Nicolas Goaziou
2013-04-26 15:26             ` Bastien
2013-04-27 17:43     ` Samuel Wales
2013-04-28  6:44       ` Bastien
2013-05-01 22:39         ` Samuel Wales

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871u9x71ss.fsf@gmail.com \
    --to=n.goaziou@gmail.com \
    --cc=bzg@altern.org \
    --cc=carsten.dominik@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --subject='Re: M-RET slow' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).