emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Eric Schulte <schulte.eric@gmail.com>
To: Rainer M Krug <Rainer@krugs.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: Deactivate babel source block
Date: Wed, 09 Oct 2013 10:28:27 -0600	[thread overview]
Message-ID: <871u3ucs7q.fsf@gmail.com> (raw)
In-Reply-To: 87vc163gya.fsf@ucl.ac.uk

Eric S Fraga <e.fraga@ucl.ac.uk> writes:

> Rainer M Krug <Rainer@krugs.de> writes:
>
> [...]
>
>> Correct me if I am wrong, but I seem to remember that source blocks
>> under a commented heading are not tangled?
>>
>> But I just tried it now, and it doesn't seem to be the case anymore -
>> code blocks under commented header are still tangled - has this feature
>> been removed or was it never there?
>
> It was there; we had a discussion about this early this year.  There is
> a commit log entry indicating that this was implemented:
>
> ,----
> | commit 8e0b4529f780de4e442d26a7ba4aedd892c78c5b
> | Author: Bastien Guerry <bzg@altern.org>
> | Date:   Thu Feb 28 10:25:21 2013 +0100
> | 
> |     ob-tangle.el (org-babel-tangle-collect-blocks): Don't collect blocks in commented out headings
> |     
> |     * ob-tangle.el (org-babel-tangle-collect-blocks): Don't
> |     collect blocks in commented out headings.
> |     
> |     Thansk to the various people who requested this.
> `----
>
> but I also found recently that code blocks in commented sections are
> indeed tangled.
>
> I have no idea what has happened to the code since.

It looks like commit 17131cb broke the heading handling of
`org-babel-tangle-collect-blocks' by removing the application of an
anonymous lambda function.

I just pushed up a fix which reapplies this function, and tangles the
following file correctly (i.e., does not tangle the commented heading).

Thanks for pointing this out.

Cheers,

-- 
Eric Schulte
https://cs.unm.edu/~eschulte
PGP: 0x614CA05D

     prev parent reply	other threads:[~2013-10-09 16:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-06  9:41 Deactivate babel source block Michael Bach
2013-10-06 15:09 ` Eric Schulte
2013-10-06 15:09 ` Eric Schulte
2013-10-06 15:23   ` Michael Bach
2013-10-07  8:31   ` Rainer M Krug
2013-10-09  9:57     ` Eric S Fraga
2013-10-09 16:28       ` Eric Schulte [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871u3ucs7q.fsf@gmail.com \
    --to=schulte.eric@gmail.com \
    --cc=Rainer@krugs.de \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).