From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bastien <bzg@gnu.org>
Subject: Re: [Patch] Few small fixes to html header
Date: Wed, 16 Apr 2014 16:50:13 +0200
Message-ID: <871twxz0bq.fsf@bzg.ath.cx>
References: <87vbuz1kky.fsf@neutrico-themes.pl>
	<20701b6c1cc0f8eda606e30a052e8e68@mail.rickster.com>
	<87txaijqug.fsf@neutrico-themes.pl>
	<9c22cfc1384fde6554e716534cb3b9c3@mail.rickster.com>
	<87siq2jj6l.fsf@neutrico-themes.pl>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51561)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@gmail.com>) id 1WaT1n-0000G3-26
	for emacs-orgmode@gnu.org; Wed, 16 Apr 2014 12:49:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bastienguerry@gmail.com>) id 1WaT1h-0008GF-CX
	for emacs-orgmode@gnu.org; Wed, 16 Apr 2014 12:49:38 -0400
Received: from mail-wg0-x233.google.com ([2a00:1450:400c:c00::233]:45535)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@gmail.com>) id 1WaT1h-0008Fy-6Z
	for emacs-orgmode@gnu.org; Wed, 16 Apr 2014 12:49:33 -0400
Received: by mail-wg0-f51.google.com with SMTP id k14so11287558wgh.10
	for <emacs-orgmode@gnu.org>; Wed, 16 Apr 2014 09:49:32 -0700 (PDT)
In-Reply-To: <87siq2jj6l.fsf@neutrico-themes.pl> (Marcin Antczak's message of
	"Fri, 28 Mar 2014 19:02:10 +0100")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Marcin Antczak <marcin.antczak@neutrico-themes.pl>
Cc: Rick Frankel <rick@rickster.com>, emacs-orgmode@gnu.org

Hi Marcin and Rick,

Marcin Antczak <marcin.antczak@neutrico-themes.pl> writes:

>> Another good question. Bastien- Do you think it makes sense to do a
>> whitespace cleanup only commit of ox-html to master?
>
> +1 from me.

The practice I've seen on Emacs is to not do whitespace commits,
but the cleanup whitespace when there is another real change.

Let's do it that way.

>> While source whitespace and output formatting are annoying, our
>> approach to modifications of this (quite old) file has been to not
>> make changes which don't materially affect functionality or fix bugs
>> (the rule of least damage :).
>
> I agree. But code really should be valid and IMHO little improvements
> and code cleanups are ok.

Agreed.  Can you submit a patch for the small enhancement you are
suggesting?  Then you can also do the whitespace cleanup.

Thanks!

-- 
 Bastien