emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* Bug: Commit cece23 'fix'-ed call to 'type' breaks my agenda sorting [8.2.7 (8.2.7-elpa @ /home/trevor/.emacs.d/elpa/org-20140613/)]
@ 2014-06-14 15:56 Trevor Murphy
  2014-06-15  8:43 ` Bastien
  0 siblings, 1 reply; 2+ messages in thread
From: Trevor Murphy @ 2014-06-14 15:56 UTC (permalink / raw)
  To: emacs-orgmode

Hi, all!   The commit named in the subject line is causing me 
grief.  Specifically, the commit made three changes to the 
`org-cmp-ts' function: 
 
 1. Change the function signature to require the `type' argument. 
 Doesn't 
    cause me any issues. 
 2 & 3. Make two changes from (get-text-property 1 'type FOO) to 
    (get-text-property 1 type FOO).  These cause problems for me. 
 
Near as I can tell, get-text-property really is supposed to look 
up the `type' property of FOO (returning "scheduled" or "deadline" 
or w/e) so the function can check that against the restriction 
passed in through the argument.

This commit has the function checking the `scheduled', `deadline', 
or other property of FOO based on the passed-in argument.  In this 
case get-text-property always returns nil and the function never 
returns anything useful.   Steps to reproduce: 
  (setq org-agenda-sorting-strategy '((agenda deadline-up))) [pull 
  up an agenda view with some deadline entries and some other 
  stuff] (setq org-agenda-sorting-strategy '((agenda 
  deadline-down))) [refresh the same agenda view] 
 
What I expect to see: 
  Deadline entries flipping from top to bottom of the agenda view. 
 
What I actually see: 
  No changes ... org-agenda-sorting-strategy doesn't appear to do 
  anything. 
 
Is this affecting anybody else?
 
Emacs  : GNU Emacs 24.3.1 (i686-pc-linux-gnu, GTK+ Version 3.10.7) 
 of 2014-01-28 on var-lib-archbuild-extra-i686-juergen 
Package: Org-mode version 8.2.7 (8.2.7-elpa @ 
/home/trevor/.emacs.d/elpa/org-20140613/) --
Trevor Murphy
GnuPG Key: 0x83881C0A

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Bug: Commit cece23 'fix'-ed call to 'type' breaks my agenda sorting [8.2.7 (8.2.7-elpa @ /home/trevor/.emacs.d/elpa/org-20140613/)]
  2014-06-14 15:56 Bug: Commit cece23 'fix'-ed call to 'type' breaks my agenda sorting [8.2.7 (8.2.7-elpa @ /home/trevor/.emacs.d/elpa/org-20140613/)] Trevor Murphy
@ 2014-06-15  8:43 ` Bastien
  0 siblings, 0 replies; 2+ messages in thread
From: Bastien @ 2014-06-15  8:43 UTC (permalink / raw)
  To: Trevor Murphy; +Cc: emacs-orgmode

Hi Trevor,

this is now fixed, thanks for reporting this!

-- 
 Bastien

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-06-15  8:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-14 15:56 Bug: Commit cece23 'fix'-ed call to 'type' breaks my agenda sorting [8.2.7 (8.2.7-elpa @ /home/trevor/.emacs.d/elpa/org-20140613/)] Trevor Murphy
2014-06-15  8:43 ` Bastien

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).