From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [patch, ox] suppress title Date: Thu, 12 Feb 2015 00:09:06 +0100 Message-ID: <871tlwvyel.fsf@nicolasgoaziou.fr> References: <871tlxcmek.fsf@gmx.us> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:48178) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLgO3-0004gf-14 for emacs-orgmode@gnu.org; Wed, 11 Feb 2015 18:08:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YLgNz-0005nX-PS for emacs-orgmode@gnu.org; Wed, 11 Feb 2015 18:08:02 -0500 Received: from relay3-d.mail.gandi.net ([2001:4b98:c:538::195]:44645) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLgNz-0005nG-JD for emacs-orgmode@gnu.org; Wed, 11 Feb 2015 18:07:59 -0500 In-Reply-To: <871tlxcmek.fsf@gmx.us> (rasmus@gmx.us's message of "Wed, 11 Feb 2015 01:38:43 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Rasmus Cc: emacs-orgmode@gnu.org Hello, Rasmus writes: > Sometime when requiring custom formatting of the header for a document, it > would be nice to be able to use #+TITLE without triggering the insertion > of the tile (e.g. \maketitle in latex and

title

in ox-html). For > instance, one might have special org-html-preamble code. This patch adds > an "#+OPTIONS: title:{nil,t}" option. Nice, thanks. The usual nitpicking follows. > - (let ((subtitle1 (plist-get attr :subtitle1)) > + (let ((title (if (plist-get info :with-title) > + title "")) Nitpick: (title (if (plist-get info :with-title) title "")) or (title (if (plist-get info :with-title) title "")) or (title (if (plist-get info :with-title) title "")) > +(make-obsolete-variable 'org-koma-letter-use-title > + 'Org-export-with-title Typo. > + (cond ((null (plist-get info :with-title)) nil) Nitpick: (not (plist-get info :with-title)) This is considered as a boolean, not as a list. > - (cond ((string= "" title) nil) > + (cond ((null (plist-get info :with-title)) nil) See above. > (defcustom org-export-time-stamp-file t > "Non-nil means insert a time stamp into the exported file. > The time stamp shows when the file was created. This option can > diff --git a/testing/lisp/test-ox.el b/testing/lisp/test-ox.el > index 79b5c69..4a74ab3 100644 > --- a/testing/lisp/test-ox.el > +++ b/testing/lisp/test-ox.el > @@ -111,7 +111,7 @@ variable, and communication channel under `info'." > (org-export--parse-option-keyword > "H:1 num:t \\n:t timestamp:t arch:t author:t creator:t d:t email:t > *:t e:t ::t f:t pri:t -:t ^:t toc:t |:t tags:t tasks:t <:t todo:t inline:nil > - stat:t") > + stat:t title:t") > '(:headline-levels > 1 :preserve-breaks t :section-numbers t :time-stamp-file t > :with-archived-trees t :with-author t :with-creator t :with-drawers t > @@ -119,7 +119,7 @@ variable, and communication channel under `info'." > :with-footnotes t :with-inlinetasks nil :with-priority t > :with-special-strings t :with-statistics-cookies t :with-sub-superscript t > :with-toc t :with-tables t :with-tags t :with-tasks t :with-timestamps t > - :with-todo-keywords t))) > + :with-title t :with-todo-keywords t))) > ;; Test some special values. > (should > (equal Could you also add a test in `test-org-export/handle-options'? This also requires a proper ORG-NEWS entry. Regards, -- Nicolas Goaziou