From mboxrd@z Thu Jan  1 00:00:00 1970
From: Aaron Ecay <aaronecay@gmail.com>
Subject: Re: [PATCH 6/9] factor out date-timestamp* calculations to
 org-store-link-props
Date: Wed, 04 Nov 2015 14:39:01 +0000
Message-ID: <871tc5x20q.fsf@gmail.com>
References: <1446581747-1960-1-git-send-email-oxij@oxij.org>
	<1446581747-1960-7-git-send-email-oxij@oxij.org>
	<87io5ivwci.fsf@gmail.com> <87io5im1hz.fsf@yin.lan>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41060)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aaronecay@gmail.com>) id 1ZtzDP-0002X1-D1
	for emacs-orgmode@gnu.org; Wed, 04 Nov 2015 09:39:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aaronecay@gmail.com>) id 1ZtzDM-0000Ea-5T
	for emacs-orgmode@gnu.org; Wed, 04 Nov 2015 09:39:07 -0500
Received: from mail-wm0-x22d.google.com ([2a00:1450:400c:c09::22d]:37532)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aaronecay@gmail.com>) id 1ZtzDL-0000EV-Uj
	for emacs-orgmode@gnu.org; Wed, 04 Nov 2015 09:39:04 -0500
Received: by wmff134 with SMTP id f134so43248876wmf.0
	for <emacs-orgmode@gnu.org>; Wed, 04 Nov 2015 06:39:03 -0800 (PST)
In-Reply-To: <87io5im1hz.fsf@yin.lan>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Jan Malakhovski <oxij@oxij.org>, emacs-orgmode@gnu.org

Hi Jan,

2015ko azaroak 4an, Jan Malakhovski-ek idatzi zuen:

[...]

>> Also, what is ignore-errors protecting? The call to date-to-time, or
>> format-time-string? I think the scope of ignore-errors should be as
>> narrow as it can be.
>=20
> I have no idea. I moved these lines from org-gnus, equivalent lines in
> org-*other-mail-reader*s don't use ignore-errors at all. I don't use
> gnus so went for the safest change.

Checking the source, date-to-time can raise an error (invalid date).
format-time-string is a C function, so it=E2=80=99s less easy for me to
understand.  But it looks like if it raises any errors, these are bugs
that we want to know about and not suppress.

The ignore-error call was introduced to org-gnus in commit 0dfde2da.
Based on the commit message, it looks like the problem being solved was
invalid dates getting passed to date-to-time.

So I think the ignore-error can just wrap the date-to-time call.

--=20
Aaron Ecay