From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [feature-request] make org-quote-csv-field customizable Date: Fri, 04 Aug 2017 00:13:44 +0200 Message-ID: <871sosl2p3.fsf@nicolasgoaziou.fr> References: <20170802102635.GS76265@r4> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:46479) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ddONc-0005C7-VB for emacs-orgmode@gnu.org; Thu, 03 Aug 2017 18:14:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ddONZ-0006cu-Td for emacs-orgmode@gnu.org; Thu, 03 Aug 2017 18:14:08 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:50565) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ddONZ-0006aw-NV for emacs-orgmode@gnu.org; Thu, 03 Aug 2017 18:14:05 -0400 In-Reply-To: <20170802102635.GS76265@r4> (Thomas von Dein's message of "Wed, 2 Aug 2017 12:26:35 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Thomas von Dein Cc: emacs-orgmode@gnu.org Hello, Thomas von Dein writes: > currently when exporting a table to CSV, fields are quoted automatically > if they contain a comma or a quote character. The regexp for this > determination is hard-coded in 'org-quote-csv-field. > > This is good for most use cases. However, if you want to import such a > CSV with MS Excel then some unquoted fields will be automatically > converted by Excel into another format. > > An example is a field containing 192.168.10.233. 'org-quote-csv-field > doesn't quote it, but Excel - for reasons I cannot fathom - considers > this a number (it doesn't do this when the last octet is below 233 > though) and converts it to 19216810233 - which is wrong. > > I wrote the following code to circumvent this Excel bug: > > (defun tvd-org-quote-csv-field (s) > "Quote every field and precede it with = to disable excel automatisms." > (if (string-match "." s) > (concat "=\"" (mapconcat 'identity > (split-string s "\"") "\"\"") "\"") > s)) > > (defun table-to-excel () > "export current org table to CSV format suitable for MS Excel." > (interactive) > ;; quote everything, map temporarily 'org-quote-csv-field > ;; to my version > (cl-letf (((symbol-function 'org-quote-csv-field) > #'tvd-org-quote-csv-field)) > (org-table-export "/tmp/ex.csv" "orgtbl-to-csv"))) > > To make this customizable, it would be good to have a variable which > contains the regex to determine what to quote. A parameter to > org-table-export would be an even better solution. It is already possible. When asked for a format for conversion, you can write something like: orgtbl-to-csv :fmt tvd-org-quote-csv-field You can also define your own format: (defun my-orgtbl-to-Excel (table params) "Convert the orgtbl-mode table to Excel. This does take care of the proper quoting of fields with comma or quotes." (orgtbl-to-generic table (org-combine-plists '(:sep "," :fmt tvd-org-quote-csv-field) params))) and use it when prompted for a format in `org-table-export'. Regards, -- Nicolas Goaziou