emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: "Michaël Cadilhac" <michael@cadilhac.name>
Cc: emacs-orgmode@gnu.org
Subject: Re: org-icalendar--combine-files aggressively releases buffers
Date: Thu, 31 Aug 2017 16:00:09 +0200	[thread overview]
Message-ID: <871snr6dna.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <CADt3fpM8_FKepcU_V-F21mwk5AHHuJzCy1aQ0sVMmdR1OVMfrw@mail.gmail.com> ("Michaël Cadilhac"'s message of "Thu, 31 Aug 2017 14:33:11 +0100")

Hello,

Michaël Cadilhac <michael@cadilhac.name> writes:

> I have an idle timer that uses org-icalendar-combine-agenda-files to
> publish my agenda.  It may well be that I hadn't saved one of the Org
> files used in there, hence when  org-icalendar--combine-files uses :
>
> (org-release-buffers org-agenda-new-buffers)
>
> …I'm prompted to save before closing some buffers.  Worst, I'm even
> asked to clock-out if I actually say yes to that question.
>
> Personally, I now expect org to leave quite a lot of .org files open
> (namely, my inbox, my todo file, my 3 gmail agendas), so I'd be fine
> with simply not having any of these closed for me.  The right thing to
> do, however, is probably to check org-agenda-new-buffers before and
> after the files are processed, and close the new ones.
>
> Opinions?

After a cursory look I think we should:

1. Remove (org-agenda-prepare-buffers files), which doesn't seem to be
   useful and can lead to errors (it can throw `nextfile') but nothing
   catches it.

2. let-bind `org-agenda-new-buffers' to nil around the unwind protect.

I pushed it in master branch. Does it solve your issue?


Regards,

-- 
Nicolas Goaziou

next prev parent reply	other threads:[~2017-08-31 14:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-31 13:33 org-icalendar--combine-files aggressively releases buffers Michaël Cadilhac
2017-08-31 14:00 ` Nicolas Goaziou [this message]
2017-08-31 15:03   ` Michaël Cadilhac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871snr6dna.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=michael@cadilhac.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).