From mboxrd@z Thu Jan 1 00:00:00 1970 From: pierre.techoueyres@free.fr (Pierre =?utf-8?Q?T=C3=A9choueyres?=) Subject: Re: [PATCH] Add new keyword :coding for #+include directive Date: Sat, 05 May 2018 00:41:37 +0200 Message-ID: <871serrqla.fsf@killashandra.ballybran.fr> References: <87tvsbx72g.fsf@killashandra.ballybran.fr> <87in8qyh3t.fsf@killashandra.ballybran.fr> <874lkakz58.fsf@nicolasgoaziou.fr> <87muy0b4kw.fsf@killashandra.ballybran.fr> <87in8lh3xk.fsf@killashandra.ballybran.fr> <87zi1uqkta.fsf@nicolasgoaziou.fr> <87in8hd7xe.fsf@killashandra.ballybran.fr> <87zi1sl0yq.fsf@nicolasgoaziou.fr> <874lk01ad6.fsf@killashandra.ballybran.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:42794) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fEjOX-0004aE-RC for emacs-orgmode@gnu.org; Fri, 04 May 2018 18:41:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fEjOW-0004w2-T8 for emacs-orgmode@gnu.org; Fri, 04 May 2018 18:41:41 -0400 Received: from smtp4-g21.free.fr ([2a01:e0c:1:1599::13]:40962) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fEjOW-0004vD-Mz for emacs-orgmode@gnu.org; Fri, 04 May 2018 18:41:40 -0400 In-Reply-To: <874lk01ad6.fsf@killashandra.ballybran.fr> ("Pierre \=\?utf-8\?Q\?T\=C3\=A9choueyres\=22's\?\= message of "Wed, 25 Apr 2018 00:57:09 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Nicolas Goaziou Cc: org-mode Hello Nicolas, Did you have time to review the patches ? pierre.techoueyres@free.fr (Pierre T=C3=A9choueyres) writes: > Hello, > Nicolas Goaziou writes: > >> Hello, >> >> pierre.techoueyres@free.fr (Pierre T=C3=A9choueyres) writes: >> >>> I think I've corrected all points. You'll find new versions attached. >> >> Thank you. >> >>> Would you mind consider to include the patch for the detection of >>> encoding with the #+include keyword in 9.2 release ? >> >> This patch is still missing some small parts for proper integration, >> namely documentation, and, if possible, a couple of tests. Besides, 9.2 >> branch is supposedly frozen. > > I argree for the documentation and tests (but I have to admit I don't > know how to add them). > >> Granted, it doesn't seem too harmful, but is there any strong reason to >> integrate it in Org 9.2 (assuming documentation is ready)? > > > I think I wasn't clear enough : I had hope you will only include the > part which correct the decoding of include keyword, not the whole two > patchs. I think the former is simply a bug fixes.=20 > > >> >>> + (coding >>> + (intern (or (and (string-match >>> + >>> ":coding[[:space:]]+\\_<\\(\\(?:\\sw\\|\\$\\|&\\|\\*\\|\\+\\|-\\|_\\|<\= \|>\\)+\\)\\_>" >>> value) >>> + (prog1 (match-string 1 value) >>> + (setq value (replace-match "" nil nil value)))) >>> + (symbol-name coding-system-for-read)))) >> >> I suggested a refactoring that you didn't integrate: it seems wasteful >> to call `intern' on the return value of `symbol-name'. >> >> Besides, my suggestion about the regexp was wrong. We shouldn't make the >> syntax foolproof. I think >> >> ":coding +\\(\\S-+\\)" >> >> is enough actually. Sorry about sending you in the wrong track. >> >> Regards, > > Here is a new amended patch. > > > > > Regards,