From: pierre.techoueyres@free.fr (Pierre Téchoueyres)
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: org-mode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] Add new keyword :coding for #+include directive
Date: Sat, 05 May 2018 00:41:37 +0200 [thread overview]
Message-ID: <871serrqla.fsf@killashandra.ballybran.fr> (raw)
In-Reply-To: <874lk01ad6.fsf@killashandra.ballybran.fr> ("Pierre \=\?utf-8\?Q\?T\=C3\=A9choueyres\=22's\?\= message of "Wed, 25 Apr 2018 00:57:09 +0200")
Hello Nicolas,
Did you have time to review the patches ?
pierre.techoueyres@free.fr (Pierre Téchoueyres) writes:
> Hello,
> Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
>
>> Hello,
>>
>> pierre.techoueyres@free.fr (Pierre Téchoueyres) writes:
>>
>>> I think I've corrected all points. You'll find new versions attached.
>>
>> Thank you.
>>
>>> Would you mind consider to include the patch for the detection of
>>> encoding with the #+include keyword in 9.2 release ?
>>
>> This patch is still missing some small parts for proper integration,
>> namely documentation, and, if possible, a couple of tests. Besides, 9.2
>> branch is supposedly frozen.
>
> I argree for the documentation and tests (but I have to admit I don't
> know how to add them).
>
>> Granted, it doesn't seem too harmful, but is there any strong reason to
>> integrate it in Org 9.2 (assuming documentation is ready)?
>
>
> I think I wasn't clear enough : I had hope you will only include the
> part which correct the decoding of include keyword, not the whole two
> patchs. I think the former is simply a bug fixes.
>
>
>>
>>> + (coding
>>> + (intern (or (and (string-match
>>> +
>>> ":coding[[:space:]]+\\_<\\(\\(?:\\sw\\|\\$\\|&\\|\\*\\|\\+\\|-\\|_\\|<\\|>\\)+\\)\\_>"
>>> value)
>>> + (prog1 (match-string 1 value)
>>> + (setq value (replace-match "" nil nil value))))
>>> + (symbol-name coding-system-for-read))))
>>
>> I suggested a refactoring that you didn't integrate: it seems wasteful
>> to call `intern' on the return value of `symbol-name'.
>>
>> Besides, my suggestion about the regexp was wrong. We shouldn't make the
>> syntax foolproof. I think
>>
>> ":coding +\\(\\S-+\\)"
>>
>> is enough actually. Sorry about sending you in the wrong track.
>>
>> Regards,
>
> Here is a new amended patch.
>
>
>
>
> Regards,
next prev parent reply other threads:[~2018-05-04 22:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-16 19:52 [PATCH] Add new keyword :coding for #+include directive Pierre Téchoueyres
2018-04-16 21:30 ` Pierre Téchoueyres
2018-04-17 8:36 ` Nicolas Goaziou
2018-04-18 18:40 ` Pierre Téchoueyres
2018-04-20 23:08 ` Pierre Téchoueyres
2018-04-23 10:27 ` Nicolas Goaziou
2018-04-23 19:44 ` Pierre Téchoueyres
2018-04-24 21:59 ` Nicolas Goaziou
2018-04-24 22:57 ` Pierre Téchoueyres
2018-05-04 22:41 ` Pierre Téchoueyres [this message]
2018-05-08 17:31 ` Nicolas Goaziou
2018-05-14 23:44 ` Pierre Téchoueyres
2018-05-19 13:13 ` Nicolas Goaziou
2018-05-19 16:09 ` Pierre Téchoueyres
2018-05-20 7:33 ` Nicolas Goaziou
2018-05-24 21:29 ` Pierre Téchoueyres
2018-06-02 10:13 ` Nicolas Goaziou
2018-06-08 19:21 ` Pierre Téchoueyres
2018-06-13 13:39 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871serrqla.fsf@killashandra.ballybran.fr \
--to=pierre.techoueyres@free.fr \
--cc=emacs-orgmode@gnu.org \
--cc=mail@nicolasgoaziou.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).