From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [PATCH] Add support for Babel with Eshell, (updated PATCH) Date: Sat, 02 Jun 2018 12:16:12 +0200 Message-ID: <871sdpo5n7.fsf@nicolasgoaziou.fr> References: <87d0ysroer.fsf@gmail.com> <87bmecrod4.fsf@gmail.com> <87a7twrmyv.fsf@gmail.com> <87po2q5kqk.fsf@nicolasgoaziou.fr> <87h8o26orj.fsf@gmail.com> <87sh7lobc5.fsf@nicolasgoaziou.fr> <87d0yptjjm.fsf@gmail.com> <87h8nzlm9x.fsf@nicolasgoaziou.fr> <87sh7i2q88.fsf@gmail.com> <87in73o7et.fsf@nicolasgoaziou.fr> <87r2lr6mzg.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:53877) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fP3a6-0007oV-Q2 for emacs-orgmode@gnu.org; Sat, 02 Jun 2018 06:16:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fP3a3-0007s5-L7 for emacs-orgmode@gnu.org; Sat, 02 Jun 2018 06:16:18 -0400 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:48985) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fP3a3-0007qN-ES for emacs-orgmode@gnu.org; Sat, 02 Jun 2018 06:16:15 -0400 In-Reply-To: <87r2lr6mzg.fsf@gmail.com> (stardiviner's message of "Fri, 01 Jun 2018 14:26:43 +0800") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: stardiviner Cc: org-mode Hello, stardiviner writes: > Aha, Thanks, Nicolas, I almost forget this patch. That's great! Speaking of which, there's an issue in `org-babel-eshell-initiate-session'. First, it uses (get-buffer (current-buffer)), which is equivalent to (current-buffer). But, more importantly, it doesn't do anything with it? So what is the point of the `progn' in that function? Regards, -- Nicolas Goaziou