From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: "Robert M. Kovacsics" <rmk35@cam.ac.uk>
Cc: Org-mode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] ob-ocaml: Support for pretty-printed outputs
Date: Sun, 13 Oct 2019 09:48:17 +0200 [thread overview]
Message-ID: <871rvhcchq.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <f66088d724dddadb59c5b7b19b846566@cam.ac.uk> (Robert M. Kovacsics's message of "Fri, 04 Oct 2019 17:52:50 +0100")
Hello,
"Robert M. Kovacsics" <rmk35@cam.ac.uk> writes:
> Subject: [PATCH] ob-ocaml: Support for pretty-printed outputs
>
> E.g. the following snippet produces multiple lines of output, due to
> pretty-printing
>
> #+BEGIN_SRC ocaml :exports code :eval no-export :results verbatim
> (* Note, no need to have parentheses around sqrt, as
> application binds the tightest *)
> let rec gamma n = if n = 0
> then (1.0 +. sqrt 5.0) /. 2.0
> else 1.0 /. (gamma (n-1) -. 1.0)
>
> let nums = List.map gamma (List.init 5 (fun x -> x))
> #+END_SRC
>
> #+NAME: gamma-tbl
> #+RESULTS[1fd6a3e846afdef51350eb6d7ba15c6844ccc14e]:
> : val gamma : int -> float = <fun>
> : val nums : float list =
> : [1.6180339887498949; 1.61803398874989468; 1.61803398874989535;
> : 1.61803398874989357; 1.61803398874989823]
>
> (In reality this would have 50 or so outputs, point being mathematically
> it shouldn't change, but due to floating point errors it does.)
>
> The regexp has the following problems:
>
> - The "." in group 5 (as-was) doesn't match new-lines, so it only
> matches the first line, e.g. as a list
> : - [1.6180339887498949, 1.61803398874989468, 1.61803398874989535,
>
> - When using "\\(.\\|\n\\)", it includes the starting indentation of the
> list, which makes org-babel-script-escape choke (called from
> org-babel-ocaml-read-list, from org-babel-ocaml-parse-output, from
> org-babel-execute:ocaml, the code being modified.
Since no-one commented your patch, I applied it. I added TINYCHANGE
cookie at the end of the commit message, since I don't know if you
signed the FSF papers already.
Thank you for your contribution!
Regards,
--
Nicolas Goaziou
prev parent reply other threads:[~2019-10-13 7:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-04 16:52 [PATCH] ob-ocaml: Support for pretty-printed outputs Robert M. Kovacsics
2019-10-13 7:48 ` Nicolas Goaziou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871rvhcchq.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=rmk35@cam.ac.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).