From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id sO7DC3wNV19YFQAA0tVLHw (envelope-from ) for ; Tue, 08 Sep 2020 04:50:04 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id SF7oB3wNV19VTwAA1q6Kng (envelope-from ) for ; Tue, 08 Sep 2020 04:50:04 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 635599403A0 for ; Tue, 8 Sep 2020 04:50:02 +0000 (UTC) Received: from localhost ([::1]:44260 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kFVZv-0006Se-Gy for larch@yhetil.org; Tue, 08 Sep 2020 00:49:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53640) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kFVZZ-0006SV-WB for emacs-orgmode@gnu.org; Tue, 08 Sep 2020 00:49:38 -0400 Received: from pb-smtp20.pobox.com ([173.228.157.52]:56173) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kFVZX-0002Ws-Qd; Tue, 08 Sep 2020 00:49:37 -0400 Received: from pb-smtp20.pobox.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id B879BDF9FC; Tue, 8 Sep 2020 00:49:32 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:in-reply-to:references:date:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=PHj0u/xx4AwR 3q/yvZnw6bRsYjo=; b=gPRIZ80SYmxRAa0z9ommzJ2R7BJ/y8aMXMl8uELZvFJh eEC1AAPpIIjCy7Hc3W8VazPC/YcSOSULHumF2goBpNU2U/6zL9tnUUtAUMb8dSAE gd+L58IaA9rDcSPK2gmdLLLn7hRwni5gh9+KyKBGaGe2PY9rwPUm7/dmCMHawJQ= Received: from pb-smtp20.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id B1ADEDF9FB; Tue, 8 Sep 2020 00:49:32 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=kyleam.com; h=from:to:cc:subject:in-reply-to:references:date:message-id:mime-version:content-type:content-transfer-encoding; s=mesmtp; bh=Kh0Afky0F9ZwFdH5+Qr50xm2R9/4LrbVvqZCVqo5giA=; b=V6Z0WVy/d8727X76HojVPjy4WqrPa3Oz2DaYv6T4w73zh1jKYdVXLg34P2Y3gmU0T0R/QceD+eHOyeyzI8kzBKwexifWNZ1Hgh9b1hI5zKAtYVxjKnLjODGG0veSpE1yAnkcIL+8wy8k+YlZal37si/q801xdYVIsw8C/a/CrSE= Received: from localhost (unknown [45.33.91.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp20.pobox.com (Postfix) with ESMTPSA id 2429FDF9FA; Tue, 8 Sep 2020 00:49:30 -0400 (EDT) (envelope-from kyle@kyleam.com) From: Kyle Meyer To: No Wayman Subject: Re: [PATCH] org-add-planning-info: respect caller's given time [9.3.7 (release_9.3.7-716-g3d4876 @ /home/n/.emacs.d/straight/build/org/)] In-Reply-To: <87blihpndy.fsf@gmail.com> References: <87zh6rfvmi.fsf@gmail.com> <87ft7wdxjl.fsf@gnu.org> <871rjgi4mb.fsf@gmail.com> <87mu239q8b.fsf@gnu.org> <87blihpndy.fsf@gmail.com> Date: Tue, 08 Sep 2020 00:49:28 -0400 Message-ID: <871rjcan53.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Pobox-Relay-ID: AE6470A6-F18E-11EA-BD4A-F0EA2EB3C613-24757444!pb-smtp20.pobox.com Received-SPF: pass client-ip=173.228.157.52; envelope-from=kyle@kyleam.com; helo=pb-smtp20.pobox.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/08 00:49:32 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bastien , Jack Kamm , emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=pobox.com header.s=sasl header.b=gPRIZ80S; dkim=fail (rsa verify failed) header.d=kyleam.com header.s=mesmtp header.b=V6Z0WVy/; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -0.01 X-TUID: bv7HYg2gJ8J3 No Wayman writes: > Unfortunately I'm unable to get the test suite to run correctly. > I've followed the instructions in the testing/README, but the=20 > tests hang due to some sort misconfiguration with python and=20 > readline on my end: > >> Warning (python): Your =E2=80=98python-shell-interpreter=E2=80=99 doesn= =E2=80=99t seem=20 >> to >> support readline, yet =E2=80=98python-shell-completion-native-enable=E2= =80=99=20 >> was t >> and "python" is not part of the >> =E2=80=98python-shell-completion-native-disabled-interpreters=E2=80=99 l= ist.=20 >> Native >> completions have been disabled locally. > > I'm running Emacs 28.0.5 on Arch linux. Searching for a solution,=20 > but haven't come up with anything useful yet. > I've tried adding (setq python-shell-completion-native-enable nil)=20 > in the --eval program from the commandline, > but this only silences the warning. Still hangs. I'll keep=20 > reseraching. Hmm, since 4df12ea39 (ob-python: Improve robustness of session evaluation, 2020-09-06), the ob-python tests stall for me as well. $ make BTEST_RE=3D'test-ob-python' test-dirty selected tests: test-ob-python Running 14 tests (2020-09-08 00:31:36-0400) Can=E2=80=99t guess python-indent-offset, using defaults: 4 executing Python code block... Shell native completion is enabled. That's on a Debian system with the python executable pointing to Python 2.7.16. If I set org-babel-python-command to python3 (3.7.3) at the top of test-ob-python.el, I see the same thing. I haven't dug any farther yet. Jack, presumably you don't see the stall on your end? No Wayman, you could try running more targeted tests to get around the stall. For example, here's how to run just tests matching "test-org/". In order to trigger the failure, I'm running it on the parent commit of 73a78c251 (Revert "org.el (org-add-planning-info): Use caller's `org-time-was-given' value", 2020-09-06). $ make BTEST_RE=3D'test-org/' test-dirty [...] Test test-org/org-read-date backtrace: signal(ert-test-failed (((should (equal "2012-03-30" (org-test-at-ti ert-fail(((should (equal "2012-03-30" (org-test-at-time "2012-03-29 (if (unwind-protect (setq value-12923 (apply fn-12921 args-12922)) ( (let (form-description-12925) (if (unwind-protect (setq value-12923 (let ((value-12923 (quote ert-form-evaluation-aborted-12924))) (let (let* ((fn-12921 (function equal)) (args-12922 (condition-case err ( (lambda nil (let* ((fn-12881 (function equal)) (args-12882 (conditio ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name test-org/org-read-date :documentation ert-run-or-rerun-test(#s(ert--stats :selector "test-org/" :tests [#s ert-run-tests("test-org/" #f(compiled-function (event-type &rest eve ert-run-tests-batch("test-org/") ert-run-tests-batch-and-exit("test-org/") (let ((org-id-track-globally t) (org-test-selector (if org-test-sele org-test-run-batch-tests("test-org/") eval((org-test-run-batch-tests org-test-select-re)) command-line-1(("--eval" "(setq vc-handled-backends nil org-startup- command-line() normal-top-level() Test test-org/org-read-date condition: (ert-test-failed ((should (equal "2012-03-30" (org-test-at-time "2012-03-29 16:40" ...))) :form (equal "2012-03-30" "2012-03-30 00:40") :value nil :explanation (arrays-of-different-length 10 16 "2012-03-30" "2012-03-30 00:40"= first-mismatch-at 10))) FAILED 76/113 test-org/org-read-date [...] As I mentioned in the message linked upstream, it doesn't happen when running just test-org/org-read-date (BTEST_RE=3D'test-org/org-read-date'), so there's some sort of interaction between tests.