emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: "Kévin Le Gouguec" <kevin.legouguec@gmail.com>
To: Kyle Meyer <kyle@kyleam.com>
Cc: Bastien <bzg@gnu.org>, emacs-orgmode@gnu.org
Subject: Check for master branch from Elisp (was: Release 9.3.8)
Date: Thu, 10 Sep 2020 08:32:35 +0200	[thread overview]
Message-ID: <871rjagn0c.fsf_-_@gmail.com> (raw)
In-Reply-To: <87bliesbmn.fsf@kyleam.com> (Kyle Meyer's message of "Wed, 09 Sep 2020 20:45:20 -0400")

Kyle Meyer <kyle@kyleam.com> writes:

> Can't you inspect the return value of org-git-version?

That can work out, though unless I'm missing something, I need to move
to the org-mode repository, ask "git branch --contains", and parse the
output.  Possible, but somewhat involved.

(TIL: git-describe's "{tag}-{nbcommits}-g{hash}" is actually a valid
revision format that other Git commands understand.)


For the sake of completeness, I've tried visiting org.el and evaluating

    (package-desc-version (package-buffer-info))

but package-buffer-info ends up calling (version-to-list "9.4-dev"),
which chokes on "-dev".  FWIW, that can be worked around with:

    (add-to-list 'version-regexp-alist (cons "^-dev$" -1))

>                                                         (Though in my
> view, distinguishing based on the functionality present with things like
> fboundp, which you mention below, is typically a better approach, if
> possible.)

Right, that's my conclusion as well :)


      reply	other threads:[~2020-09-10  6:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-07 15:49 Release 9.3.8 Bastien
2020-09-07 17:23 ` Kévin Le Gouguec
2020-09-07 17:45   ` Bastien
2020-09-08  5:35     ` Kévin Le Gouguec
2020-09-09  8:17       ` Bastien
2020-09-10  0:45         ` Kyle Meyer
2020-09-10  6:32           ` Kévin Le Gouguec [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871rjagn0c.fsf_-_@gmail.com \
    --to=kevin.legouguec@gmail.com \
    --cc=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=kyle@kyleam.com \
    --subject='Re: Check for master branch from Elisp (was: Release 9.3.8)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).