emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: "Sébastien Miquel" <sebastien.miquel@posteo.eu>
Cc: emacs-orgmode@gnu.org, Rasmus <rasmus@gmx.us>
Subject: Re: [patch] fix ox-latex async export bug
Date: Mon, 29 Nov 2021 22:39:32 +0100	[thread overview]
Message-ID: <871r2y3aln.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <ae2ab5f1-ee7e-5e3a-504e-fef5da3448a2@posteo.eu> ("Sébastien Miquel"'s message of "Mon, 29 Nov 2021 09:19:20 +0000")

Hello,

Sébastien Miquel <sebastien.miquel@posteo.eu> writes:

> Attached is a patch that applies the same fix where affected.

Thank you. It mostly looks good, but I have one nit.

> -      (lambda (file)
> -	(run-hook-with-args 'org-icalendar-after-save-hook file) nil))))
> +      '(lambda (file)
> +	 (run-hook-with-args 'org-icalendar-after-save-hook file) nil))))

This is not really the same fix. You're quoting a lambda, which should
not be required if the problem disappeared. IOW, the true fix probably
belong in the `org-export-async-start' function.

WDYT?

Regards,
-- 
Nicolas Goaziou

next prev parent reply	other threads:[~2021-11-29 21:40 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-28 15:59 [patch] fix ox-latex async export bug Rasmus
2021-11-28 19:52 ` Nicolas Goaziou
2021-11-28 22:54   ` Tim Cross
2021-11-29  5:15     ` Timothy
2021-11-30 19:46       ` Rasmus
2021-11-29  9:19   ` Sébastien Miquel
2021-11-29 21:39     ` Nicolas Goaziou [this message]
2021-11-30 11:58       ` Sébastien Miquel
2021-12-10  9:30         ` Nicolas Goaziou
2021-11-30 19:35     ` Rasmus Pank Roulund
2021-12-01  6:40       ` Sébastien Miquel
2021-12-01  8:06         ` Rasmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871r2y3aln.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=rasmus@gmx.us \
    --cc=sebastien.miquel@posteo.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).