emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@gmail.com>
To: Alan Ruttenberg <alanruttenberg@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: ob-lisp determining package
Date: Fri, 29 Apr 2022 17:20:31 +0800	[thread overview]
Message-ID: <871qxg8cv4.fsf@localhost> (raw)
In-Reply-To: <CAFKQJ8=2ptR=7UFJOS8V1z=-cn3AbS3r2+b+faG+xAX9fReyeg@mail.gmail.com>

Alan Ruttenberg <alanruttenberg@gmail.com> writes:

> I propose that the package determination be changed to
>
> (or (cdr (assq :package params)) (funcall org-babel-lisp-package-fn))
>
> with org-babel-lisp-package-fn being bound analogous to how
> org-babel-lisp-eval-function is:
>
>  (require (pcase org-babel-lisp-package-fn
>     (`slime-current-package  'slime)
>     (`sly-current-pacakge 'sly)))
>
> This (approximately) seems to work fine in my emacs. However, I am using an
> older version of emacs/org-mode and so am not submitted a patch, which
> would be against slightly different code.

Did you have a chance to test your changes against the latest Org?
If everything works fine, could you prepare a patch?

best,
Ihor


      reply	other threads:[~2022-04-29  9:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-27  1:25 Alan Ruttenberg
2022-04-29  9:20 ` Ihor Radchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871qxg8cv4.fsf@localhost \
    --to=yantar92@gmail.com \
    --cc=alanruttenberg@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --subject='Re: ob-lisp determining package' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).