emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@gmail.com>
To: "André A. Gomes" <andremegafone@gmail.com>, Bastien <bzg@gnu.org>
Cc: emacs-orgmode@gnu.org
Subject: Re: [BUG] org-table-blank-field keybinding [9.5.4 (N/A @ /gnu/store/sry9khwisaq1jnrjbfnhx6ki8qy2z0db-emacs-org-9.5.4/share/emacs/site-lisp/org-9.5.4/)]
Date: Mon, 12 Sep 2022 18:40:23 +0800	[thread overview]
Message-ID: <871qsgx4dk.fsf@localhost> (raw)
In-Reply-To: <87y1uq3r86.fsf@gmail.com>

Bastien, could you kindly confirm that this kind of patch fits into
TINYCHANGE? The changes are trivial, so we should not need to look at
the line count here, right?

André A. Gomes <andremegafone@gmail.com> writes:

>>>>> Also, it might be worth mentioning in the manual that this command works
>>>>> when a region is selected.
>>>>
>>>> Indeed M-x  does work when region is selected. Just
>>>> as documented.
>>>
>>> I meant in the manual, not in the docstring.  But perhaps it does
>>> suffice as it is.
>>
>> Would you mind making a patch for the manual?
>> See https://orgmode.org/worg/org-contribute.html
>
> Please find the patch attached.  Thanks.

The patch appears to be for
https://orgmode.org/list/878s1xupey.fsf@gmail.com
André A. Gomes <andremegafone@gmail.com> (2021-07-23)
Subject: Headings and Headlines

where we agreed to rename "headline" to "heading" in the manual,
function names, and comments.

Note that this thread is about a different manual issue -
org-table-blank-field documentation.

In any case, thank you very much for the patch. Even though it is
related to a different email thread, it is still providing an improvement
to our manual.

Note that "Fix documentation" is very vague. In future, please try to be
more specific about what the patch does. E.g.

    Rename "headline" to "heading" in documentation

You can refer to
https://orgmode.org/worg/org-contribute.html#commit-messages for the
conventions we use in the commit messages.

I am not yet merging the patch until Bastien confirms that the patch can
be marked TINYCHANGE and does not require copyright assignment (see
https://orgmode.org/worg/org-contribute.html#copyright). Otherwise, the
patch looks good.

-- 
Ihor Radchenko,
Org mode contributor,
Learn more about Org mode at https://orgmode.org/.
Support Org development at https://liberapay.com/org-mode,
or support my work at https://liberapay.com/yantar92


  reply	other threads:[~2022-09-12 10:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-25 20:35 [BUG] org-table-blank-field keybinding [9.5.4 (N/A @ /gnu/store/sry9khwisaq1jnrjbfnhx6ki8qy2z0db-emacs-org-9.5.4/share/emacs/site-lisp/org-9.5.4/)] André A. Gomes
2022-08-26 13:35 ` Ihor Radchenko
2022-08-26 13:45   ` André A. Gomes
2022-08-26 14:30     ` Ihor Radchenko
2022-09-11 14:44       ` André A. Gomes
2022-09-12 10:40         ` Ihor Radchenko [this message]
2022-09-17 12:18           ` Bastien
2022-12-10 13:56       ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871qsgx4dk.fsf@localhost \
    --to=yantar92@gmail.com \
    --cc=andremegafone@gmail.com \
    --cc=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).