emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@posteo.net>
To: Tim Ruffing <crypto@timruffing.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Don't reset `org-todo-keywords-for-agenda' when org-agenda-multi
Date: Fri, 10 Mar 2023 11:48:03 +0000	[thread overview]
Message-ID: <871qlwzv2k.fsf@localhost> (raw)
In-Reply-To: <55a16edf3c8e04e9f1f7be7ab281ddacac81d9c1.camel@timruffing.de>

Tim Ruffing <crypto@timruffing.de> writes:

> * org-agenda.el (org-prepare-agenda): Don't reset
> `org-todo-keywords-for-agenda' when org-agenda-multi.
> Fixes a bug with TODO keywords that came to light in org-modern,
> see https://github.com/minad/org-modern/issues/26.
> This is very similar to cd2d138883a55cad48394a3f473da8b973a99a5e,
> which fixed the same for `org-done-keywords-for-agenda` (to fix
> a similar styling issue).

Thanks for the patch!
Unfortunately, it does not apply.
Could you re-send the patch as attachment?

In addition, may you add TINYCHANGE cookie to the commit message if you
don't have FSF assignment done (see
https://orgmode.org/worg/org-contribute.html#first-patch)? And, if you
can, write a test.

Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

  reply	other threads:[~2023-03-10 11:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-09 12:46 [PATCH] Don't reset `org-todo-keywords-for-agenda' when org-agenda-multi Tim Ruffing
2023-03-10 11:48 ` Ihor Radchenko [this message]
2023-03-10 12:08   ` Tim Ruffing
2023-03-10 12:32   ` Max Nikulin
2023-03-10 14:16     ` Tim Ruffing
2023-03-11 10:22       ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871qlwzv2k.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=crypto@timruffing.de \
    --cc=emacs-orgmode@gnu.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).