emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Leo Butler <Leo.Butler@umanitoba.ca>
To: Ihor Radchenko <yantar92@posteo.net>
Cc: Org Mode Mailing List <emacs-orgmode@gnu.org>
Subject: Re: org-cite: how to force a reparsing of the .bib file
Date: Wed, 23 Aug 2023 16:47:33 +0000	[thread overview]
Message-ID: <871qftk8nv.fsf@t14.reltub.ca> (raw)
In-Reply-To: <87y1i26rzu.fsf@localhost> (Ihor Radchenko's message of "Wed, 23 Aug 2023 09:13:41 +0000")

On Wed, Aug 23 2023, Ihor Radchenko <yantar92@posteo.net> wrote:

> Leo Butler <Leo.Butler@umanitoba.ca> writes:
>
>> Does org-cite monitor contents or the timestamp?
>> I am using a symlink to the bib file.
>
> Timestamp.
>
> Does the attached patch fix the problem?

Thanks, Ihor.

To avoid an unneeded setq, I applied the patch:

      (dolist (file (mapcar #'file-truename (org-cite-list-bibliography-files)))

This caused the bibtex file to be re-parsed when I changed it.

Best,
Leo

>
> From 39b503301fc7a3ea68733dfd9e4391e3f84efec8 Mon Sep 17 00:00:00 2001
> Message-ID: <39b503301fc7a3ea68733dfd9e4391e3f84efec8.1692781998.git.yantar92@posteo.net>
> From: Ihor Radchenko <yantar92@posteo.net>
> Date: Wed, 23 Aug 2023 12:12:13 +0300
> Subject: [PATCH] oc-basic: Fix detecting changes in symlinked bibliography
>
> * lisp/oc-basic.el (org-cite-basic--parse-bibliography): Use
> `file-truename' to follow symlinks first before checking bibliography
> file change times.
>
> Reported-by: Leo Butler <Leo.Butler@umanitoba.ca>
> Link: https://orgmode.org/list/877cpmkds1.fsf@t14.reltub.ca
> ---
>  lisp/oc-basic.el | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/lisp/oc-basic.el b/lisp/oc-basic.el
> index 84d9492ea..c4468e5a8 100644
> --- a/lisp/oc-basic.el
> +++ b/lisp/oc-basic.el
> @@ -272,6 +272,9 @@ (defun org-cite-basic--parse-bibliography (&optional info)
>        (plist-get info :cite-basic/bibliography)
>      (let ((results nil))
>        (dolist (file (org-cite-list-bibliography-files))
> +        ;; Follow symlinks, to look into modification time of the
> +        ;; actual file, not its symlink.
> +        (setq file (file-truename file))
>          (when (file-readable-p file)
>            (with-temp-buffer
>              (when (or (org-file-has-changed-p file)
> -- 
> 2.41.0

next prev parent reply	other threads:[~2023-08-23 16:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-22 18:35 org-cite: how to force a reparsing of the .bib file Leo Butler
2023-08-22 18:48 ` Ihor Radchenko
2023-08-22 20:44   ` Leo Butler
2023-08-23  9:13     ` Ihor Radchenko
2023-08-23 16:47       ` Leo Butler [this message]
2023-08-24  7:22         ` Ihor Radchenko
2023-08-24 17:57           ` Leo Butler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871qftk8nv.fsf@t14.reltub.ca \
    --to=leo.butler@umanitoba.ca \
    --cc=emacs-orgmode@gnu.org \
    --cc=yantar92@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).