From: Thomas Alexander Gerds <tag@biostat.ku.dk>
To: emacs-orgmode@gnu.org, Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: proposed change of org-gnus-store-link for nnir groups
Date: Thu, 17 Dec 2015 07:14:12 +0100 [thread overview]
Message-ID: <86y4ctfvpn.fsf@biostat.ku.dk> (raw)
In-Reply-To: <871tamaynu.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of "Wed, 16 Dec 2015 22:09:25 +0100")
[-- Attachment #1: Type: text/plain, Size: 1764 bytes --]
great. the updated patch is attached. for ORG-NEWS:
,----
| *** Links
| **** Links stored by org-gnus-store-link in nnir groups
|
| Since gnus nnir groups are temporary, org-gnus-store-link
| now refers to the article's original group.
`----
best
Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
> Hello,
>
> Thomas Alexander Gerds <tag@biostat.ku.dk> writes:
>
>> sometimes after searching for mail with notmuch, I want to save a
>> link to one of the articles shown in the nnir summary. since nnir
>> groups are temporary I would like org-gnus-store-link to treat nnir
>> groups differently and to use the articles orginal group when
>> creating the link. the following 3 lines change of
>> org-gnus-store-link does this for me. if this is interesting for
>> others maybe it could be integrated ... if not, I could either
>> advice org-gnus-store-link or add a modified version to
>> org-store-link-functions. comments?
>
> Sounds good. Thank you.
>
>> (when (eq (car (gnus-find-method-for-group
>> gnus-newsgroup-name)) 'nnvirtual) (setq group (car
>> (nnvirtual-map-article (gnus-summary-article-number))))) + (when (eq
>> (car (gnus-find-method-for-group gnus-newsgroup-name)) + 'nnir) +
>> (setq group (nnir-article-group (gnus-summary-article-number))))
>
> I think the above could be wrapped within a cl-case, if only to
> compute (car (gnus-find-method-for-group gnus-newsgroup-name)) only
> once. Also, it may require an entry in ORG-NEWS, and a proper commit
> message.
>
> Would you mind sending an updated patch?
>
> Regards,
Thomas A. Gerds -- Assoc. Prof. Department of Biostatistics
University of Copenhagen, Oester Farimagsgade 5, 1014 Copenhagen, Denmark
Office: CSS-15.2.07 (Gamle Kommunehospital)
tel: 35327914 (sec: 35327901)
[-- Attachment #2: patch-org-gnus.txt --]
[-- Type: text/plain, Size: 1110 bytes --]
commit f56d29a57ed965029c1b5f3929f3085423e46f18
Author: Thomas Alexander Gerds <tag@biostat.ku.dk>
Date: Thu Dec 17 06:57:11 2015 +0100
org-gnus: avoid links to nnir groups
diff --git a/lisp/org-gnus.el b/lisp/org-gnus.el
index c7b46af..06ba4df 100644
--- a/lisp/org-gnus.el
+++ b/lisp/org-gnus.el
@@ -172,10 +172,12 @@ If `org-store-link' was called with a prefix arg the meaning of
(subject (copy-sequence (mail-header-subject header)))
(to (cdr (assq 'To (mail-header-extra header))))
newsgroups x-no-archive desc link)
- (when (eq (car (gnus-find-method-for-group gnus-newsgroup-name))
- 'nnvirtual)
- (setq group (car (nnvirtual-map-article
- (gnus-summary-article-number)))))
+ (cl-case (car (gnus-find-method-for-group gnus-newsgroup-name))
+ (nnvirtual
+ (setq group (car (nnvirtual-map-article
+ (gnus-summary-article-number)))))
+ (nnir
+ (setq group (nnir-article-group (gnus-summary-article-number)))))
;; Remove text properties of subject string to avoid Emacs bug
;; #3506
(set-text-properties 0 (length subject) nil subject)
next prev parent reply other threads:[~2015-12-17 6:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-12 9:55 proposed change of org-gnus-store-link for nnir groups Thomas Alexander Gerds
2015-12-16 21:09 ` Nicolas Goaziou
2015-12-17 6:14 ` Thomas Alexander Gerds [this message]
2015-12-17 8:57 ` Nicolas Goaziou
2015-12-18 6:49 ` Thomas Alexander Gerds
2015-12-18 21:45 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86y4ctfvpn.fsf@biostat.ku.dk \
--to=tag@biostat.ku.dk \
--cc=emacs-orgmode@gnu.org \
--cc=mail@nicolasgoaziou.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).