emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: "Sebastien Vauban" <sva-news-D0wtAvR13HarG/iDocfnWg@public.gmane.org>
To: emacs-orgmode-mXXj517/zsQ@public.gmane.org
Subject: Re: [babel] Specified colnames
Date: Sat, 27 Apr 2013 18:06:51 +0200	[thread overview]
Message-ID: <86li84vtyc.fsf@somewhere.org> (raw)
In-Reply-To: 87txms2f0f.fsf@gmail.com


Eric Schulte wrote:
>> Here the patch you asked for.
> I've applied this patch.

Thanks a lot for reviewing my test, and fixing it!

> Please review the changes I had to make for it to work correctly. Your
> version wasn't working because when org-babel-execute-src-block was called
> the point was not inside of the code block.

Isn't there something to fix, in order to avoid an uncontrolled error to be
generated, such as the one I had?

> My changes search forward in the text to place the point at the beginning of
> the code block before executing.


> I also had to uppercase RESULTS for the string equality to return true.

OK. That's true I've set:

--8<---------------cut here---------------start------------->8---
  ;; keep lower-case
  (setq org-babel-results-keyword "results")
--8<---------------cut here---------------end--------------->8---

since we've got nice keyword fontification -- as Carsten once said, he only
choose uppercase keywords, a while ago, when it was much more difficult to
clearly view the distinction between text, code and results (before the nice
fontification we now have). Otherwise, he'd have chosen lower-case keywords.

Because of that feature, which I completely had out of my mind, I'm thinking
at another thing that could help reduce the size of the tests. Currently, we
copy once the code block, and once the code block + its results.

Maybe we could have a function to locate (via a regexp for
#+results/#+RESULTS) the results, and only check (for strict or loose
equality [1]) on the results.

So, something along those lines:

--8<---------------cut here---------------start------------->8---
 (equal (results-part (org-babel-execute-src-block "code block only"))
        "results only"))
--8<---------------cut here---------------end--------------->8---

No duplication of the input...

Does this make sense?

> In the future more flexible tests (such as regular expression searches)
> rather than strict equality should be preferable.
> Thanks for contributing this test!

My pleasure.

Best regards,

[1] Regexp match

Sebastien Vauban

  reply	other threads:[~2013-04-27 16:06 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-07 20:11 [babel] Specified colnames Sebastien Vauban
2013-04-08 16:41 ` Eric Schulte
2013-04-08 19:45   ` Sebastien Vauban
2013-04-08 20:15     ` Eric Schulte
2013-04-08 20:49       ` Sebastien Vauban
2013-04-12 21:42         ` Eric Schulte
2013-04-18 21:25           ` Sebastien Vauban
2013-04-20 10:11             ` Eric Schulte
2013-04-25 13:28               ` Sebastien Vauban
2013-04-27 15:02                 ` Eric Schulte
2013-04-27 16:06                   ` Sebastien Vauban [this message]
2013-04-27 16:47                     ` Eric Schulte

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86li84vtyc.fsf@somewhere.org \
    --to=sva-news-d0wtavr13harg/idocfnwg@public.gmane.org \
    --cc=emacs-orgmode-mXXj517/zsQ@public.gmane.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).