From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Sebastien Vauban" <sva-news-D0wtAvR13HarG/iDocfnWg@public.gmane.org>
Subject: Re: [PATCH] Re: Can't export LaTeX source code blocks
Date: Fri, 03 May 2013 22:40:29 +0200
Message-ID: <86ip2zkdaa.fsf@somewhere.org>
References: <86obd67427.fsf@somewhere.org> <87zjwqb9wd.fsf@gmail.com>
	<867gju6xyd.fsf@somewhere.org> <m17gjumcdz.fsf@poto.westell.com>
	<86ip38xriz.fsf@somewhere.org> <86bo90xq6y.fsf_-_@somewhere.org>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org-mXXj517/zsQ@public.gmane.org>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request-mXXj517/zsQ@public.gmane.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode-mXXj517/zsQ@public.gmane.org>
List-Help: <mailto:emacs-orgmode-request-mXXj517/zsQ@public.gmane.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request-mXXj517/zsQ@public.gmane.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org-mXXj517/zsQ@public.gmane.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org-mXXj517/zsQ@public.gmane.org
To: emacs-orgmode-mXXj517/zsQ@public.gmane.org
Cc: Eric Schulte <schulte.eric-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

Hi Eric,

Could you look at this patch, fixing the priority hierarchy of Babel header
arguments, and apply it, if judged OK?

Best regards,
  Seb

"Sebastien Vauban" wrote:
> "Sebastien Vauban" wrote:
>> Thomas S. Dye wrote:
>>> "Sebastien Vauban" writes:
>>>
>>>>>> The code block is NEVER exported. I don't understand why?
>>>>>
>>>>> I'm not sure either.
>>>
>>> I took a quick look at ob-latex.el. The code there sets `:exports
>>> results' and then, IIUC, goes on its way without checking if :exports
>>> has been set in the buffer.
>>>
>>> It looks to me like ob-latex.el would need to be revised.
>>
>> I don't have the impression that the error lies in `ob-latex' as the other
>> `ob-LANG' files don't either make any special check -- while all graphics-only
>> languages do, as well, have the default of "results" for ":exports".
>>
>> I have the impression the problem is to search in `ob-core'
>> (`org-babel-execute-src-block') or `ob-exp'... But that's not yet clear to me
>> where that could be.
>
> I think I found it. That was a priority order problem for implementing the
> hierarchy of header arguments inheritage in `ob-core'.
>
> Best regards,
>   Seb
>
> From 3339c0f7d296fc68a206b0f69270da3a91025840 Mon Sep 17 00:00:00 2001
> From: Sebastien Vauban <sva-news-4+nxiYgPiI0PTC0C9HXcdqsb+IOhx+da@public.gmane.org>
> Date: Sat, 27 Apr 2013 11:40:25 +0200
> Subject: [PATCH 2/2] Fix priority order for inheriting header arguments
>
> * ob-core.el (org-babel-parse-src-block-match): Fix order of list of header
> arguments.
>
> ---
>  lisp/ob-core.el |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lisp/ob-core.el b/lisp/ob-core.el
> index 9baff0c..73dca8f 100644
> --- a/lisp/ob-core.el
> +++ b/lisp/ob-core.el
> @@ -1,6 +1,6 @@
>  ;;; ob-core.el --- working with code blocks in org-mode
>  
> -;; Copyright (C) 2009-2012  Free Software Foundation, Inc.
> +;; Copyright (C) 2009-2013  Free Software Foundation, Inc.
>  
>  ;; Authors: Eric Schulte
>  ;;	Dan Davison
> @@ -1323,8 +1323,8 @@ may be specified in the properties of the current outline entry."
>                (buffer-string)))
>  	  (org-babel-merge-params
>  	   org-babel-default-header-args
> -           (org-babel-params-from-properties lang)
>  	   (if (boundp lang-headers) (eval lang-headers) nil)
> +           (org-babel-params-from-properties lang)
>  	   (org-babel-parse-header-arguments
>              (org-no-properties (or (match-string 4) ""))))
>  	  switches
> -- 
> 1.7.9

-- 
Sebastien Vauban