emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: "Sebastien Vauban" <sva-news-D0wtAvR13HarG/iDocfnWg@public.gmane.org>
To: emacs-orgmode-mXXj517/zsQ@public.gmane.org
Cc: Eric Schulte <schulte.eric-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] Re: Can't export LaTeX source code blocks
Date: Fri, 03 May 2013 22:40:29 +0200	[thread overview]
Message-ID: <86ip2zkdaa.fsf@somewhere.org> (raw)
In-Reply-To: <86bo90xq6y.fsf_-_@somewhere.org>

Hi Eric,

Could you look at this patch, fixing the priority hierarchy of Babel header
arguments, and apply it, if judged OK?

Best regards,
  Seb

"Sebastien Vauban" wrote:
> "Sebastien Vauban" wrote:
>> Thomas S. Dye wrote:
>>> "Sebastien Vauban" writes:
>>>
>>>>>> The code block is NEVER exported. I don't understand why?
>>>>>
>>>>> I'm not sure either.
>>>
>>> I took a quick look at ob-latex.el. The code there sets `:exports
>>> results' and then, IIUC, goes on its way without checking if :exports
>>> has been set in the buffer.
>>>
>>> It looks to me like ob-latex.el would need to be revised.
>>
>> I don't have the impression that the error lies in `ob-latex' as the other
>> `ob-LANG' files don't either make any special check -- while all graphics-only
>> languages do, as well, have the default of "results" for ":exports".
>>
>> I have the impression the problem is to search in `ob-core'
>> (`org-babel-execute-src-block') or `ob-exp'... But that's not yet clear to me
>> where that could be.
>
> I think I found it. That was a priority order problem for implementing the
> hierarchy of header arguments inheritage in `ob-core'.
>
> Best regards,
>   Seb
>
> From 3339c0f7d296fc68a206b0f69270da3a91025840 Mon Sep 17 00:00:00 2001
> From: Sebastien Vauban <sva-news-4+nxiYgPiI0PTC0C9HXcdqsb+IOhx+da@public.gmane.org>
> Date: Sat, 27 Apr 2013 11:40:25 +0200
> Subject: [PATCH 2/2] Fix priority order for inheriting header arguments
>
> * ob-core.el (org-babel-parse-src-block-match): Fix order of list of header
> arguments.
>
> ---
>  lisp/ob-core.el |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lisp/ob-core.el b/lisp/ob-core.el
> index 9baff0c..73dca8f 100644
> --- a/lisp/ob-core.el
> +++ b/lisp/ob-core.el
> @@ -1,6 +1,6 @@
>  ;;; ob-core.el --- working with code blocks in org-mode
>  
> -;; Copyright (C) 2009-2012  Free Software Foundation, Inc.
> +;; Copyright (C) 2009-2013  Free Software Foundation, Inc.
>  
>  ;; Authors: Eric Schulte
>  ;;	Dan Davison
> @@ -1323,8 +1323,8 @@ may be specified in the properties of the current outline entry."
>                (buffer-string)))
>  	  (org-babel-merge-params
>  	   org-babel-default-header-args
> -           (org-babel-params-from-properties lang)
>  	   (if (boundp lang-headers) (eval lang-headers) nil)
> +           (org-babel-params-from-properties lang)
>  	   (org-babel-parse-header-arguments
>              (org-no-properties (or (match-string 4) ""))))
>  	  switches
> -- 
> 1.7.9

-- 
Sebastien Vauban

  reply	other threads:[~2013-05-03 20:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-22 19:34 Sebastien Vauban
2013-04-22 20:14 ` Nicolas Goaziou
2013-04-22 21:46   ` Sebastien Vauban
2013-04-22 22:25     ` Thomas S. Dye
2013-04-24 21:32       ` Sebastien Vauban
2013-04-27  9:16       ` Sebastien Vauban
2013-04-27  9:45         ` [PATCH] " Sebastien Vauban
2013-05-03 20:40           ` Sebastien Vauban [this message]
2013-05-06 20:32           ` Eric Schulte

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86ip2zkdaa.fsf@somewhere.org \
    --to=sva-news-d0wtavr13harg/idocfnwg@public.gmane.org \
    --cc=emacs-orgmode-mXXj517/zsQ@public.gmane.org \
    --cc=schulte.eric-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --subject='Re: [PATCH] Re: Can'\''t export LaTeX source code blocks' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).