emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Sebastien Vauban <sva-news-D0wtAvR13HarG/iDocfnWg@public.gmane.org>
To: emacs-orgmode-mXXj517/zsQ@public.gmane.org
Subject: Re: org-block-background in 8.3.1?
Date: Wed, 12 Aug 2015 09:44:09 +0200	[thread overview]
Message-ID: <86h9o5kl2u.fsf@example.com> (raw)
In-Reply-To: 87wpx1b4tu.fsf@kmlap.domain.org

Kyle Meyer <kyle-4Wn5G85RAV/QT0dZR+AlfA@public.gmane.org> writes:
> Luke Crook <luke-bul7fGZb+kRBDgjK7y7TUQ@public.gmane.org> wrote:
>> I'm not sure if I still need to set "org-block-background" in 8.3.1.
>>
>> But if I do need to continue setting this, what is the new name for "org-
>> block-background"?
>>
>> (set-face-attribute 'org-block-background nil
>>                     :height (round (* 0.9 (face-attribute 'fixed-pitch
>> :height))))
>> (set-face-attribute 'org-block nil
>>                     :height (round (* 0.9 (face-attribute 'fixed-pitch
>> :height))))
>
> org-block-background was removed in f8b42e8 ("Don't use an overlay for
> src blocks backgrounds", 2014-07-28) for performance reasons.

IIRC, we never saw a profiler report showing that it slowed down buffer
fontification in a visible way.  Correct me if I'm wrong.

Really, it has been removed because of a problem when ps-print'ing an
Org buffer -- though the bug was to find in `ps-def.el' and not in Org,
as reported by Stefan Monnier [1].  It should have been fixed there
instead.

> I'm not aware of anything that has been introduced in its place.

I'm planning to reintroduce it as an optional feature.  At least in my
personal Git repository, if that's not accepted in Org core.

Best regards,
  Seb

[1] http://lists.gnu.org/archive/html/emacs-devel/2014-07/msg00403.html

-- 
Sebastien Vauban

  reply	other threads:[~2015-08-12  7:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-12  2:31 org-block-background in 8.3.1? Luke Crook
2015-08-12  2:47 ` Kyle Meyer
2015-08-12  7:44   ` Sebastien Vauban [this message]
2015-08-12 16:55     ` Kyle Meyer
2015-08-18 17:26     ` Bastien
2015-08-19 10:13       ` Sebastien Vauban
2015-08-19 10:29         ` Bastien
  -- strict thread matches above, loose matches on Subject: below --
2015-08-20  8:33 JI, Xiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86h9o5kl2u.fsf@example.com \
    --to=sva-news-d0wtavr13harg/idocfnwg@public.gmane.org \
    --cc=emacs-orgmode-mXXj517/zsQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).