emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* bug with org-clone-subtree-with-time-shift?
@ 2013-04-19 20:05 Ingmar Meissner
  2013-04-19 20:37 ` David Rogers
  2013-04-20  7:02 ` Bastien
  0 siblings, 2 replies; 8+ messages in thread
From: Ingmar Meissner @ 2013-04-19 20:05 UTC (permalink / raw)
  To: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 419 bytes --]

Hi,

it seems to me that "org-clone-subtree-with-time-shift" is not working correct with org-mode 8.0. Usually i could specify a time shift, but not anymore. Did i miss something?

Ingmar Meissner

P.S. By the way, thanks for all the good work on org-mode!

********************************************
Ingmar Meissner
info@ingmarmeissner.de
********************************************











[-- Attachment #2: Type: text/html, Size: 6114 bytes --]

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: bug with org-clone-subtree-with-time-shift?
  2013-04-19 20:05 bug with org-clone-subtree-with-time-shift? Ingmar Meissner
@ 2013-04-19 20:37 ` David Rogers
  2013-04-23  8:43   ` [Bug] " Karl Voit
  2013-04-20  7:02 ` Bastien
  1 sibling, 1 reply; 8+ messages in thread
From: David Rogers @ 2013-04-19 20:37 UTC (permalink / raw)
  To: emacs-orgmode

Ingmar Meissner <info@ingmarmeissner.de> writes:

> Hi,
>
> it seems to me that "org-clone-subtree-with-time-shift" is not working
> correct with org-mode 8.0. Usually i could specify a time shift, but
> not anymore. Did i miss something?

Hi Ingmar

I had the same problem; it's not a bug, it still works, just the default
behaviour has been changed for 8.0.

The change is that the time-shift is no longer automatic. Now, before
you type

C-c C-x c

you need to type

C-u

first, so that the whole command is "C-u C-c C-x c", if you want the
time shift. Otherwise, you get a plain clone with no time
shift. (Before, you had to press extra keys to get a plain clone, now
you have to press extra keys to get a time-shifted clone.)

-- 
David

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: bug with org-clone-subtree-with-time-shift?
  2013-04-19 20:05 bug with org-clone-subtree-with-time-shift? Ingmar Meissner
  2013-04-19 20:37 ` David Rogers
@ 2013-04-20  7:02 ` Bastien
  1 sibling, 0 replies; 8+ messages in thread
From: Bastien @ 2013-04-20  7:02 UTC (permalink / raw)
  To: Ingmar Meissner; +Cc: emacs-orgmode

Hi Ingmar,

Ingmar Meissner <info@ingmarmeissner.de> writes:

> it seems to me that "org-clone-subtree-with-time-shift" is not
> working correct with org-mode 8.0. Usually i could specify a time
> shift, but not anymore. Did i miss something?

David explanations are correct, but your email made me think I've
been too heavy-handed with this change.

It makes more sense to skip the time-shift prompt when there is no
time-stamp and to have it by default when there is a time-stamp.  So
this is now how the command behaves.  And when called with C-u, it
will skip the time-shift prompt unconditionally.

Thanks for bringing this up!

-- 
 Bastien

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug] Re: bug with org-clone-subtree-with-time-shift?
  2013-04-19 20:37 ` David Rogers
@ 2013-04-23  8:43   ` Karl Voit
  2013-04-23  9:59     ` Bastien
  0 siblings, 1 reply; 8+ messages in thread
From: Karl Voit @ 2013-04-23  8:43 UTC (permalink / raw)
  To: emacs-orgmode

* David Rogers <davidandrewrogers@gmail.com> wrote:
> Ingmar Meissner <info@ingmarmeissner.de> writes:

Hi!

>> it seems to me that "org-clone-subtree-with-time-shift" is not working
>> correct with org-mode 8.0. Usually i could specify a time shift, but
>> not anymore. Did i miss something?
>
> I had the same problem; it's not a bug, it still works, just the default
> behaviour has been changed for 8.0.
>
> The change is that the time-shift is no longer automatic. Now, before
> you type
>
> C-c C-x c
>
> you need to type
>
> C-u
>
> first, so that the whole command is "C-u C-c C-x c", if you want the
> time shift. Otherwise, you get a plain clone with no time
> shift.

Thanks for clearing this issue, David.

I totally agree with Ingmar that this is definitely a bug:

The function is called "org-clone-subtree-with-time-shift" and in
its default behavior (without the universal argument), it does *not*
shift time.

When a user does "M-x org-clone-subtree-with-time-shift" and there
is no time shift, she/he gets irritated - just like Ingmar, just like
I was.


To me, the desired behavior should be like this:

org-clone-subtree ... the same behavior as David described above for
          the current situation of org-clone-subtree-with-time-shift
          with an optional universal argument to ask for time shift
          if you want.

org-clone-subtree-with-time-shift ... the old behavior where the
          user gets asked about the time shift

What function of those two is mapped to "C-c C-x c" is an
independent defined issue.

I would love to see this bug fixed.

-- 
mail|git|SVN|photos|postings|SMS|phonecalls|RSS|CSV|XML to Org-mode:
       > get Memacs from https://github.com/novoid/Memacs <

https://github.com/novoid/extract_pdf_annotations_to_orgmode + more on github

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [Bug] Re: bug with org-clone-subtree-with-time-shift?
  2013-04-23  8:43   ` [Bug] " Karl Voit
@ 2013-04-23  9:59     ` Bastien
  2013-04-23 10:18       ` Karl Voit
  0 siblings, 1 reply; 8+ messages in thread
From: Bastien @ 2013-04-23  9:59 UTC (permalink / raw)
  To: Karl Voit; +Cc: news1142, emacs-orgmode

Hi Karl,

Karl Voit <devnull@Karl-Voit.at> writes:

> I would love to see this bug fixed.

I've applied a fix and replied here:
http://article.gmane.org/gmane.emacs.orgmode/70904

Can you double-check it works as you like?

Thanks!

-- 
 Bastien

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [Bug] Re: bug with org-clone-subtree-with-time-shift?
  2013-04-23  9:59     ` Bastien
@ 2013-04-23 10:18       ` Karl Voit
  2013-04-23 11:56         ` Bastien
  0 siblings, 1 reply; 8+ messages in thread
From: Karl Voit @ 2013-04-23 10:18 UTC (permalink / raw)
  To: emacs-orgmode

* Bastien <bzg@gnu.org> wrote:
> Hi Karl,

Hi!

> Karl Voit <devnull@Karl-Voit.at> writes:
>
>> I would love to see this bug fixed.
>
> I've applied a fix and replied here:
> http://article.gmane.org/gmane.emacs.orgmode/70904
>
> Can you double-check it works as you like?

I've seen commit 2a192ff6c (Apr 20) from you and I checked out again
(commit 4873682e, Apr 23 11:51) but following heading with
org-clone-subtree-with-time-shift does not ask for a time shift
here:

* <2013-05-07 Tue +1w> Test
:PROPERTIES:
:CREATED:  [2013-05-07 Tue 10:29]
:END:

Is a misunderstanding on my side what "when there is a time-stamp"
means?

-- 
mail|git|SVN|photos|postings|SMS|phonecalls|RSS|CSV|XML to Org-mode:
       > get Memacs from https://github.com/novoid/Memacs <

https://github.com/novoid/extract_pdf_annotations_to_orgmode + more on github

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [Bug] Re: bug with org-clone-subtree-with-time-shift?
  2013-04-23 10:18       ` Karl Voit
@ 2013-04-23 11:56         ` Bastien
  2013-04-23 12:16           ` Karl Voit
  0 siblings, 1 reply; 8+ messages in thread
From: Bastien @ 2013-04-23 11:56 UTC (permalink / raw)
  To: Karl Voit; +Cc: news1142, emacs-orgmode

Hi Karl,

Karl Voit <devnull@Karl-Voit.at> writes:

> I've seen commit 2a192ff6c (Apr 20) from you and I checked out again
> (commit 4873682e, Apr 23 11:51) but following heading with
> org-clone-subtree-with-time-shift does not ask for a time shift
> here:
>
> * <2013-05-07 Tue +1w> Test
> :PROPERTIES:
> :CREATED:  [2013-05-07 Tue 10:29]
> :END:

I just tried this and it does ask for the time-shift here.
There is tiny bug about the "+1w" not being repeated for new
headlines, but that's different.

-- 
 Bastien

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [Bug] Re: bug with org-clone-subtree-with-time-shift?
  2013-04-23 11:56         ` Bastien
@ 2013-04-23 12:16           ` Karl Voit
  0 siblings, 0 replies; 8+ messages in thread
From: Karl Voit @ 2013-04-23 12:16 UTC (permalink / raw)
  To: emacs-orgmode

* Bastien <bzg@gnu.org> wrote:
> Hi Karl,

Hi!

> Karl Voit <devnull@Karl-Voit.at> writes:
>
>> I've seen commit 2a192ff6c (Apr 20) from you and I checked out again
>> (commit 4873682e, Apr 23 11:51) but following heading with
>> org-clone-subtree-with-time-shift does not ask for a time shift
>> here:
>>
>> * <2013-05-07 Tue +1w> Test
>> :PROPERTIES:
>> :CREATED:  [2013-05-07 Tue 10:29]
>> :END:
>
> I just tried this and it does ask for the time-shift here.
> There is tiny bug about the "+1w" not being repeated for new
> headlines, but that's different.

Sorry, my fault. After compiling my org-mode checkout the issue
is fixed at my side as well.

-- 
mail|git|SVN|photos|postings|SMS|phonecalls|RSS|CSV|XML to Org-mode:
       > get Memacs from https://github.com/novoid/Memacs <

https://github.com/novoid/extract_pdf_annotations_to_orgmode + more on github

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2013-04-23 12:16 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-04-19 20:05 bug with org-clone-subtree-with-time-shift? Ingmar Meissner
2013-04-19 20:37 ` David Rogers
2013-04-23  8:43   ` [Bug] " Karl Voit
2013-04-23  9:59     ` Bastien
2013-04-23 10:18       ` Karl Voit
2013-04-23 11:56         ` Bastien
2013-04-23 12:16           ` Karl Voit
2013-04-20  7:02 ` Bastien

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).