From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 2Ju+HT6jzGFjMQEAgWs5BA (envelope-from ) for ; Wed, 29 Dec 2021 19:04:46 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id aLRjFj6jzGHlaAEAG6o9tA (envelope-from ) for ; Wed, 29 Dec 2021 19:04:46 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DFA8C3487E for ; Wed, 29 Dec 2021 19:04:45 +0100 (CET) Received: from localhost ([::1]:38810 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n2dJd-0006wD-3a for larch@yhetil.org; Wed, 29 Dec 2021 13:04:45 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56602) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n2dIv-0006w0-Oa for emacs-orgmode@gnu.org; Wed, 29 Dec 2021 13:04:02 -0500 Received: from devianza.investici.org ([198.167.222.108]:60933) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n2dIt-00079H-Jm for emacs-orgmode@gnu.org; Wed, 29 Dec 2021 13:04:01 -0500 Received: from mx2.investici.org (unknown [127.0.0.1]) by devianza.investici.org (Postfix) with ESMTP id 4JPK613MN5z6vFr for ; Wed, 29 Dec 2021 18:03:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mortemale.org; s=stigmate; t=1640801033; bh=z9wldq6FVRUGUS7tvk5FwNd9XMtReSChtbV0i/bsZ6M=; h=From:To:Subject:Date:From; b=P0WHyRxzz4H9zXqj/QuXlU1fGDve7FbxBucmg5re0W4Oya7KvqyLYZIIut+WVAaUs p8VrBeB2MMwFp4Nz8GHdodjep8H6SlmzxyzJda3sfYkCcNLR+6McuW/3WIq4eUd+hO UL9mh5tiqjuzhlNGZZwx1HAs1vjGcP7IOQcoOfzE= Received: from [198.167.222.108] (mx2.investici.org [198.167.222.108]) (Authenticated sender: felipelema@mortemale.org) by localhost (Postfix) with ESMTPSA id 4JPK6105Tpz6v6H for ; Wed, 29 Dec 2021 18:03:52 +0000 (UTC) From: Felipe Lema To: emacs-orgmode@gnu.org Subject: [PATCH] update ob-scheme to latest changes in geiser package Date: Wed, 29 Dec 2021 15:03:47 -0300 Message-ID: <8693346.QgZh8Glrbv@felipe-thinkpad-x200> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="nextPart12537058.GFbceAY9VS" Content-Transfer-Encoding: 7Bit Received-SPF: pass client-ip=198.167.222.108; envelope-from=felipelema@mortemale.org; helo=devianza.investici.org X-Spam_score_int: -1 X-Spam_score: -0.2 X-Spam_bar: / X-Spam_report: (-0.2 / 5.0 requ) DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1640801086; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=z9wldq6FVRUGUS7tvk5FwNd9XMtReSChtbV0i/bsZ6M=; b=LNe70sqf5LhcL7XjO3P8Fz9n7b5CBIcJ+2jGT4WV7QQI/U0aPNBFMWvjBkyAkTSb4/8veJ NF9RODcl+Gw02lUHX/BVjr61+0z85UpFfEpSHB/4B6KeSSNJmTj2tNJezRYCMGvAX7BwTw l9nW0lBK7+xKY7rpACWEleiBsOIR0hL8dGuHcf9YopmT0BaJKCK0zwwRXGbYxe81NngYMy TmXvrWXnbx3P5eiYP1FPW8Dz74zGc7M8llhNWQfpqhm8mrv4Te8taY7fMVhgoGF9WmTm8T FZ27+yJokZIQL/uKclcZZlc3oKVBQD2Hr3T5xMRgctQxSxodIFd+JFqjKS+E7A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1640801086; a=rsa-sha256; cv=none; b=JmyQ1IQZA7/4bNuPX7BUeFMmNi58NNzrSiCCAZNibH+C6YnYDf2KtXvNZ2XjLoZErTKja0 sBMtfwj65BDoSlpHcN94JkVAOFsvD2T5nvwgQ9iCHKbScZh3khk3OWgcmujd6N/o8Bt5/x /Q6YUtxveIC2wFtpOxye/fxMSgM3XOGMWYprwwIUgbtqzoRDypxZqEz6eQYDiYEQcFoSER SMMwFpaM2QPH9mwDRccjHo3v7cwk+oYCWvXTbyuXB3IAqsbX1oxKQzrzk8NeUon/Wwgt+Q et4uNtsChOICcg1Z14OCv8sRM/wSLRxoGg/u/rYv0HbzAXYh/lKXnT9hnHuecA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=mortemale.org header.s=stigmate header.b=P0WHyRxz; dmarc=pass (policy=reject) header.from=mortemale.org; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -8.07 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=mortemale.org header.s=stigmate header.b=P0WHyRxz; dmarc=pass (policy=reject) header.from=mortemale.org; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: DFA8C3487E X-Spam-Score: -8.07 X-Migadu-Scanner: scn0.migadu.com X-TUID: WHQGpCaRrGug This is a multi-part message in MIME format. --nextPart12537058.GFbceAY9VS Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sup, y'all The geiser package had a recent update in which `geiser-eval-region` behaves like an async function and does not return evaluation result. In exchange, the newly introduced `geiser-eval-region/wait` does that now. I've attached a patch to update ob-scheme.el to reflect these changes. Without them, evaluating scheme dialect code blocks in Org will end up with empty results. To learn more about the change (and how it impacted other people's flows) see issue thread below https://gitlab.com/emacs-geiser/geiser/-/issues/30 Felipe --nextPart12537058.GFbceAY9VS Content-Disposition: attachment; filename="org-babel-scheme-geiser-eval-region.wait.diff" Content-Transfer-Encoding: 7Bit Content-Type: text/x-patch; charset="utf-8"; name="org-babel-scheme-geiser-eval-region.wait.diff" update to new API call to evaluate region and wait for result * ob-scheme.el replace `geiser-eval-region` with `geiser-eval-region/wait` as the former changed expected behaviour; the latter returns the result of evaluating. diff --git a/lisp/org/ob-scheme.el b/lisp/org/ob-scheme.el index f4836b23fe..89c6abf686 100644 --- a/lisp/org/ob-scheme.el +++ b/lisp/org/ob-scheme.el @@ -176,7 +176,7 @@ org-babel-scheme-execute-with-geiser (setq geiser-impl--implementation nil) (let ((geiser-debug-jump-to-debug-p nil) (geiser-debug-show-debug-p nil)) - (let ((ret (geiser-eval-region (point-min) (point-max)))) + (let ((ret (geiser-eval-region/wait (point-min) (point-max)))) (setq result (if output (or (geiser-eval--retort-output ret) "Geiser Interpreter produced no output") --nextPart12537058.GFbceAY9VS--