From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sebastien Vauban Subject: Re: 63 failures for org-test-run-all-tests in an Emacs GUI Date: Wed, 24 Dec 2014 13:39:14 +0100 Message-ID: <861tnpmdcd.fsf@example.com> References: <86zjaf7knu.fsf@example.com> <87ioh12x25.fsf@nicolasgoaziou.fr> <8661d1mj6h.fsf@example.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org-mXXj517/zsQ@public.gmane.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org-mXXj517/zsQ@public.gmane.org To: emacs-orgmode-mXXj517/zsQ@public.gmane.org Sebastien Vauban wrote: > Nicolas Goaziou wrote: >> Sebastien Vauban writes: >> >>> I just ran `org-test-run-all-tests' in my active WinNT Emacs session >>> (with Org-mode release_8.3beta-677-g0497e3), and was surprised by >>> the high number of failures: >> >> You probably heavily customized Org > > For sure ;-) > >> and many tests expect default values for defcustoms to run properly. >> >> I fixed the most obvious one, but there is more work to do in that >> area. > > IIUC, the "top 1" problem for test failures is my customization of > `org-babel-no-eval-on-ctrl-c-ctrl-c' to `t'. > > For the tests to work with that (common?) customization, should we > replace, in the tests, all calls to: > > (org-ctrl-c-ctrl-c) > > by: > > (let (org-babel-no-eval-on-ctrl-c-ctrl-c) > (org-ctrl-c-ctrl-c)) > > ? In fact, what would make more sense is to have a `org-ctrl-c-ctrl-v-ctrl-e' function, no? Or even more sense: calling `org-babel-execute-maybe' instead? Best regards, Seb -- Sebastien Vauban