From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id UMNkGWzZE2ZSJAEAe85BDQ:P1 (envelope-from ) for ; Mon, 08 Apr 2024 13:47:56 +0200 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id UMNkGWzZE2ZSJAEAe85BDQ (envelope-from ) for ; Mon, 08 Apr 2024 13:47:56 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gnu.org header.s=fencepost-gnu-org header.b=WRY3UOhs; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1712576876; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=oMTbSrdhoOEZSF4dVY6ZTo7kc6RVefoXMaNJdoMXOZI=; b=DbbrZqds0DsFiJevE6ss5B6kPcOQAmf21hijPO5ctVvxrP9drGLlezDC476suZFzEUhybq 4qPJZFTEtNJpulUWAVh2IUAPAvjYWwCfN5b2VaHskni7GUlba4jstdyzJkaFUUYwCebvd3 zW4ILmxZ7QuZGQT6i5cjaBiYD5fnL68HI+NieWNWIhwyeoDeaMtD0MNDrWfLiUuEhbUsZC 9rSo03uj9JtJTaYZmHlJJ/vnIq5ZcZfGNZQ2K5mScJfZqkd3UEccYBkYXC3oJ8lHcKCFyC YaPTERmPAWHuGiTVz2Ubt+fzzJagZpXOhRU9ek6CI7sR6RD2l8W8r7NeslNzUQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1712576876; a=rsa-sha256; cv=none; b=EWWXPQFlzeHBDr6Up3phL1p477jeMK/YUWqQj2sUjeepGcvjK3qpNoahqyoSKlKLRCOx8w Hp3Lj60bS1eGg5fZ7Z4k1aDmbVKoKKaUzCJSJ61zDpJEVfn/IlWEhH3oo+GLDoW8+wLQ/k L0V2X6nG9yvkNHyeDHawFZB8K42iCrkp8gugrJFXegLHs5KF6abz8tBYYEfO1nmyghIKYN GicNHPXR4Udioo1VGLT8xJU5ooq7FHmwkWzonYTJPMAlCglwkE8GDFpW14EYXjEP1DV01d +8gqJqWjUnYNydvQNgBtjZt21aIxzas8Lc0/JRgWuNOIi5t1HAG7XY+7l4CHQA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gnu.org header.s=fencepost-gnu-org header.b=WRY3UOhs; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 47EEB10650 for ; Mon, 8 Apr 2024 13:47:56 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rtnSY-0000UE-49; Mon, 08 Apr 2024 07:46:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rtnSH-0000TF-RP; Mon, 08 Apr 2024 07:46:30 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rtnSF-0000l2-ST; Mon, 08 Apr 2024 07:46:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=oMTbSrdhoOEZSF4dVY6ZTo7kc6RVefoXMaNJdoMXOZI=; b=WRY3UOhsDnOywzs7dolJ ixpunfKvUSBvGxdNaojQ9M342C6e5prwBlGc/FtrUkG7Ya7+lvqzoYk3ynl+VrKmam2ZvmuOCXPEw 829MODTs6ewHGyL0nbO9MfPk93TPF3xBg2olIaV4uVH1PQeSH6AVV6f1t80BG6XT7SLgtz4LqKXEY Cg+Rou3DkNGmrixI6mGlz75gd19j/c0eGdi48IVN8mleqDkecYNgZh9Fr8+G5MM8RvedcJYncxoZQ NGreIF/RQHT+2+VSKWMqc7iR4USkqTlalGaN1Go43WxNrpARK+JV9LnGbsJgQdDOaqX8Uz0Bnvf9D /r/oKZZy8azD3g==; Date: Mon, 08 Apr 2024 14:46:24 +0300 Message-Id: <861q7gyt4f.fsf@gnu.org> From: Eli Zaretskii To: =?utf-8?Q?S=C5=82awomir?= Grochowski Cc: yantar92@posteo.net, emacs-orgmode@gnu.org, emacs-devel@gnu.org, philipk@posteo.net, stefankangas@gmail.com, larsi@gnus.org, hmelman@gmail.com, info@protesilaos.com In-Reply-To: <87frvwl2wv.fsf@gmail.com> (message from =?utf-8?Q?S=C5=82awo?= =?utf-8?Q?mir?= Grochowski on Mon, 08 Apr 2024 09:38:40 +0200) Subject: Re: [DISCUSSION] "quick-help" popup for org-columns (column view) References: <87a5oayblv.fsf@gmail.com> <87jzlxro68.fsf@localhost> <87zfu6b4w3.fsf@gmail.com> <86jzl91zrd.fsf@gnu.org> <87frvwl2wv.fsf@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -7.51 X-Spam-Score: -7.51 X-Migadu-Queue-Id: 47EEB10650 X-Migadu-Scanner: mx13.migadu.com X-TUID: v6dGLEv/9xGP > From: SÅ‚awomir Grochowski > Cc: yantar92@posteo.net, emacs-orgmode@gnu.org, emacs-devel@gnu.org, > philipk@posteo.net, stefankangas@gmail.com, larsi@gnus.org, > hmelman@gmail.com, info@protesilaos.com > Date: Mon, 08 Apr 2024 09:38:40 +0200 > > > The idea here was that some other function could rebind > > `help-quick-sections' dynamically. That way you avoid the redundant > > arguments (which would all have to be documented). > > Is this really a good practice? > Relying on global variables instead of passing variables as a parameters? Emacs is full of such practices, so don't worry about that, it's quite common (and considered good practice) in Emacs Lisp. > Eli Zaretskii writes: > > In any case, we cannot change the signature of help-quick, since it's a > > public function. > > If I can't modify the function `help-quick' how can I make it work? You write a new function with the signature you like and make help-quick call it to do the actual job. Where you want to use the signature of the new function, you call it directly.