From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tim Schumacher Subject: org-show-notification of org-clock.el broken on MS Windows Date: Fri, 24 Jan 2020 10:08:59 +0100 Message-ID: <85sgk52pck.wl-tim@datenknoten.me> Mime-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:57116) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iuuxf-0005PC-DG for emacs-orgmode@gnu.org; Fri, 24 Jan 2020 04:09:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iuuxd-00082n-Ty for emacs-orgmode@gnu.org; Fri, 24 Jan 2020 04:09:06 -0500 Received: from mx.datenknoten.me ([2a01:4f8:200:2265:3:100:0:7]:41667) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iuuxd-0007u9-Fm for emacs-orgmode@gnu.org; Fri, 24 Jan 2020 04:09:05 -0500 Received: from DESKTOP-QF7GSBC.datenknoten.me (p54988E7E.dip0.t-ipconnect.de [84.152.142.126]) by mx.datenknoten.me (Postfix) with ESMTPSA id 80E3C109B7E for ; Fri, 24 Jan 2020 10:08:59 +0100 (CET) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org Sender: "Emacs-orgmode" To: emacs-orgmode@gnu.org Hi folks, I have a snippet that clocks me in, if I set the TOOD-keyword of an item to started. So some time after working on that item on and off, I got a stack trace and it would not change the keyword to started. The error was, that emacs was not compiled with dbus support and I thought, hell yeah, I'm on MS Windows, I don't have dbus here. So I looked at the stack trace and found org-clock-notify-once-if-expired which wants to show a notification if I took longer than I estimated. Than digging deeper I found org-show-notification which is where the actual error happens. It checks if the function notifications-notify exists and then tries to use it. On my system the function is available, but does not work because I don't have dbus support. In my opinion these two actionable items should be done: * The function org-show-notification should be more robust. It should not fail if it can't fire a notification for whatever reason. * On MS Windows the function w32-notification-notify should be used. Maybe someone has a quick fix, if not I can try my non existant elisp foo and hack together a patch tomorrow, but please be gentle with me. Thanks for your time and great effort into org-mode! Tim