From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Dominik Subject: Re: Outline and org-mode don't insert text into folded sections logically Date: Wed, 2 Nov 2011 13:53:48 +0100 Message-ID: <85DD63EE-538B-4ADC-A40A-1880FC040C59@gmail.com> References: <1315077299.1785.YahooMailClassic@web121520.mail.ne1.yahoo.com> <837h5nh1df.fsf@yahoo.it> <877h3xibb0.fsf@gnu.org> <81ehy5uy0t.fsf@gmail.com> <87wrbxdter.fsf@gnu.org> <877h3n7usn.fsf@gnu.org> <87hb2ru7qf.fsf@gnu.org> <87vcr7srij.fsf@gnu.org> <87k47ns2vx.fsf@gnu.org> <6CBBC924-DD81-46F0-B8ED-EC92D9B6A2AE@gmail.com> <87ehxuzw80.fsf@gnu.org> <87aa8eu34y.fsf@altern.org> Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([140.186.70.92]:36213) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RLaKI-0004eN-ID for emacs-orgmode@gnu.org; Wed, 02 Nov 2011 08:54:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RLaKH-0002Zz-FG for emacs-orgmode@gnu.org; Wed, 02 Nov 2011 08:53:54 -0400 Received: from mail-ey0-f169.google.com ([209.85.215.169]:56724) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RLaKH-0002Zp-4F for emacs-orgmode@gnu.org; Wed, 02 Nov 2011 08:53:53 -0400 Received: by eye4 with SMTP id 4so111518eye.0 for ; Wed, 02 Nov 2011 05:53:52 -0700 (PDT) In-Reply-To: <87aa8eu34y.fsf@altern.org> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Bastien Cc: emacs-orgmode@gnu.org, Kelly Dean On Nov 2, 2011, at 11:10 AM, Bastien wrote: > Hi Carsten, > > Carsten Dominik writes: > >> please find enclosed a patch which is my proposal for rounding >> off this feature. > > thanks for the clean implementation. > > There is a small typo: the second (let ...) should be (let* ...), > see attached updated patch. OK, I will take a look at it and then push. > >> It introduces a variable, applies the check to org-delete-char >> and org-delete-backward-char, and removes the (sit-for 1), >> and it never moves the cursor. > > Okay. It also applies the check for `org-self-insert-command'. > > I like the variable's name. > > Nitpicking: > > - (setq org-catch-invisible-edits 'show-and-error) is the same than > (setq org-catch-invisible-edits t), right? Can we document this > somewhere, so that users know what to expect from setting the variable > to t? Will do. > > - From the docstring: "[...] or add in the middle or right after an > invisible region" -- I agree inserting while in the middle of the > invisible region would feel too unpredictable, but I'd argue that > inserting *right after* the invisible region when point is at the end > of it feels okay. Nevermind, maybe this request will come up later, > I'm fine with your current solution. I tried, and it confused the hell out of me... :D > >> I have been unsing it for a day or two, and I like the `smart' >> setting of the variable. Even though, I do agree with your >> earlier post that the default should be nil. > > Okay. Please feel free to apply a patch when you want. > > Thanks! Cheers - Carsten > > > -- > Bastien - Carsten